Pass scheme to support Secure cookies in sunstone#771
Merged
tinova merged 1 commit intoOpenNebula:masterfrom Oct 10, 2019
Merged
Pass scheme to support Secure cookies in sunstone#771tinova merged 1 commit intoOpenNebula:masterfrom
tinova merged 1 commit intoOpenNebula:masterfrom
Conversation
Signed-off-by: xBytez <git@xbytez.io>
xBytez
force-pushed
the
feautre/sunstone-pass-scheme
branch
from
94d127a to
c4c3c55
Compare
tinova
approved these changes
Oct 10, 2019
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend the user to pass Forwarded-For and Forwarded-Proto scheme to let Sinatra know what the URL scheme requested is.
The URL scheme is useful so Sunstone can potentially set cookies with a Secure flag.
It's also potentially useful (in the future?) to let Sinatra know what the real request address is, so I've included that.