F #3738: Secure cookie flag if scheme is https#3738
Merged
tinova merged 1 commit intoOpenNebula:masterfrom Oct 10, 2019
Merged
Conversation
xBytez
force-pushed
the
feature/make-cookies-secure
branch
from
d400a0e to
8c67de2
Compare
xBytez
changed the title
xBytez
added a commit
to xBytez/one
that referenced
this pull request
Sep 19, 2019
Signed-off-by: xBytez <git@xbytez.io>
xBytez
force-pushed
the
feature/make-cookies-secure
branch
from
8c67de2 to
c831802
Compare
xBytez
changed the title
Signed-off-by: xBytez <git@xbytez.io>
xBytez
force-pushed
the
feature/make-cookies-secure
branch
from
c831802 to
cdce88e
Compare
Member
|
Hi, thanks a lot for your quality contribution! About GitCop, you can check the guidelines here: https://github.com/OpenNebula/one/blob/master/share/doc/dev/COMMIT_MESSAGES.md |
tinova
approved these changes
Oct 10, 2019
Member
|
Thanks! |
rsmontero
pushed a commit
that referenced
this pull request
Aug 4, 2025
Signed-off-by: josepselga <jselga@opennebula.io>
rsmontero
pushed a commit
that referenced
this pull request
Aug 4, 2025
Signed-off-by: josepselga <jselga@opennebula.io> (cherry picked from commit 46de81c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build in functionality so Sunstone marks cookies set as Secure to ensure only secure servers can access the session cookie.
I've also made a PR to OpenNebula/docs to document this change.
PS: It'd be nice to have a ISSUE_TEMPLATE so I know what GitCop expects so I don't make this mistake of writing PRs this way.