Flatten all button appearances; confirm default-profile contrast is sound#3
Merged
Merged
Conversation
…ound Add src/common/ExtrasolarPlanetsButtonOptions.ts with ButtonNode.FlatAppearanceStrategy bundles (push buttons, ResetAllButton, TimeControlNode play/pause/step, NumberControl arrow buttons) and wire them into both screens' Reset All / TimeControlNode and into createNumberControl's arrow buttons, matching the flat-button pattern already used in RotatingSky. Audited every ComboBox, NumberDisplay, and readout for the near-white-text- on-white-background contrast bug seen in sibling repos; confirmed no fix is needed here since ExtrasolarPlanetsColors.textColorProperty is dark in both default and projector profiles, which reads fine against the unstyled white ComboBox/NumberDisplay chrome. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018svZaRUmD44JWTQJLUYdmx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add src/common/ExtrasolarPlanetsButtonOptions.ts with ButtonNode.FlatAppearanceStrategy
bundles (push buttons, ResetAllButton, TimeControlNode play/pause/step, NumberControl
arrow buttons) and wire them into both screens' Reset All / TimeControlNode and into
createNumberControl's arrow buttons, matching the flat-button pattern already used in
RotatingSky. Audited every ComboBox, NumberDisplay, and readout for the near-white-text-
on-white-background contrast bug seen in sibling repos; confirmed no fix is needed here
since ExtrasolarPlanetsColors.textColorProperty is dark in both default and projector
profiles, which reads fine against the unstyled white ComboBox/NumberDisplay chrome.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_018svZaRUmD44JWTQJLUYdmx