Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,16 @@
}
}
}
},
{
"includes": ["tests/**"],
"linter": {
"rules": {
"nursery": {
"useExplicitType": "off"
}
}
}
}
],
"javascript": {
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default defineConfig({
timeout: 10_000,
},
fullyParallel: false,
forbidOnly: !!process.env.CI,
forbidOnly: !!process.env["CI"],
retries: 0,
workers: 1,
reporter: [["list"], ["html", { open: "never" }]],
Expand All @@ -24,7 +24,7 @@ export default defineConfig({
webServer: {
command: "npm run start",
url: "http://localhost:5173",
reuseExistingServer: !process.env.CI,
reuseExistingServer: !process.env["CI"],
timeout: 120_000,
},
projects: [
Expand Down
1 change: 0 additions & 1 deletion src/common/TimeModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
* import { TimeControlNode } from "scenerystack/scenery-phet";
*
* const timeControl = new TimeControlNode( model.timer.isPlayingProperty, {
* timeSpeedProperty: model.timer.timeSpeedProperty, // optional
* playPauseStepButtonOptions: {
* stepForwardButtonOptions: {
* listener: () => model.step( 1 / 60 ),
Expand Down
10 changes: 8 additions & 2 deletions src/i18n/StringManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,17 @@ import stringsEs from "./strings_es.json";
import stringsFr from "./strings_fr.json";

// ── Compile-time key-parity check ─────────────────────────────────────────────
// TypeScript errors here if any locale file is missing a key from English.
// English is the canonical shape; every other locale must match it exactly.
// TypeScript errors here if any locale file is missing (or adds) a key relative to
// English. Add one `satisfies` line per new locale so the check stays exhaustive.
// biome-ignore lint/complexity/noVoid: intentional compile-time type assertion
void (stringsFr satisfies typeof stringsEn);
// biome-ignore lint/complexity/noVoid: intentional compile-time type assertion
void (stringsEn satisfies typeof stringsFr);
// biome-ignore lint/complexity/noVoid: intentional compile-time type assertion
void (stringsFr satisfies typeof stringsEn);
void (stringsEs satisfies typeof stringsEn);
// biome-ignore lint/complexity/noVoid: intentional compile-time type assertion
void (stringsEn satisfies typeof stringsEs);

// ── Build the reactive string property tree ───────────────────────────────────
const stringProperties = LocalizedString.getNestedStringProperties({
Expand Down
3 changes: 0 additions & 3 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,3 @@ onReadyToLaunch(() => {

sim.start();
});
// hook test
// test
// test
2 changes: 1 addition & 1 deletion tsconfig.scripts.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"noEmit": true,
"types": ["node"]
},
"include": ["scripts"]
"include": ["scripts", "*.config.ts"]
}