Skip to content

Preserve RNG state in dataset iteration #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kovbo merged 3 commits into from
Jun 4, 2026
Merged

Preserve RNG state in dataset iteration #681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c2b15
Preserve RNG state in dataset iteration
pragnyanramtha May 17, 2026
c95ab80
Merge branch 'main' into fix-iterate-dataset-rng-state
pragnyanramtha May 19, 2026
313ce0e
Remove iterate_dataset tests from PR
Kovbo Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/art/utils/iterate_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ def iterate_dataset(
for epoch in range(num_epochs):
# Create indices and shuffle deterministically based on epoch
indices = list(range(dataset_size))
random.seed(epoch) # Ensure shuffling is the same for a given epoch
random.shuffle(indices)
random.Random(epoch).shuffle(indices)

for i in range(0, dataset_size, groups_per_step):
epoch_step = i // groups_per_step
Expand Down