Skip to content

Conversation

@luca-vercelli
Copy link
Contributor

Updated translations for 2.4.x
I updated translations on https://hosted.weblate.org/projects/cups/cups/it/, then I downloaded updated .po file. I hope this is the correct workflow.
If I am not wrong, translations on Weblate are from 2.4.x, not from master.

@zdohnal
Copy link
Member

zdohnal commented Sep 23, 2024

Hi @luca-vercelli ,

thank you for the PR!

AFAIK translations in Weblate are for master branch (and we have to add it into master first, to prevent future regressions) - probably all the new msgids in the end of the PR are for master branch.

Would you mind removing them from this PR? Please do not squash commits, it takes lots of time to review big changes like this, so add your changes as a new commit in your PR.

Copy link
Member

@zdohnal zdohnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in the comment - please remove the new English strings from the end of PR, since they look like for master branch, and we are good to go.

"Il file ~/.cups/lpoptions fa riferimento a una destinazione predefinita che "
"non esiste."

#, c-format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new strings from here to the end look like from master branch, please remove them since the PR is for 2.4.x branch.

@luca-vercelli
Copy link
Contributor Author

I removed strings as requested.
What should I do about master? Should I provide a new PR with the same (full) file?

@zdohnal
Copy link
Member

zdohnal commented Sep 24, 2024

@luca-vercelli I will try to put your commit from 2.4.x into master - it will hopefully take less time than reviewing big MR :D .

@luca-vercelli
Copy link
Contributor Author

luca-vercelli commented Sep 25, 2024 via email

@zdohnal zdohnal self-requested a review February 13, 2025 12:42
Copy link
Member

@zdohnal zdohnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zdohnal zdohnal merged commit eb02560 into OpenPrinting:2.4.x Feb 13, 2025
@zdohnal
Copy link
Member

zdohnal commented Feb 13, 2025

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants