cupsd.conf: Remove IdleExitTimeout if no ondemand support#1216
cupsd.conf: Remove IdleExitTimeout if no ondemand support#1216michaelrsweet merged 1 commit intoOpenPrinting:masterfrom
Conversation
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
See comment. You might also leave the comment in cupsd.conf.in and set EXIT_TIMEOUT to # IdleExitTimeout support not enabled. so that someone looking at the cupsd.conf file will see that the on-demand code was compiled in...
| AS_IF([test "x$withval" = "xno"], [ | ||
| EXIT_TIMEOUT=0 | ||
| AS_IF([test x$with_ondemand != xno], [ | ||
| AC_ARG_WITH([idle_exit_timeout], AS_HELP_STRING([--with-idle-exit-timeout], [set the default value for IdleExitTimeout, default=60]), [ |
There was a problem hiding this comment.
Don't we need to set EXIT_TIMEOUT to the empty string if --without-ondemand is specified?
There was a problem hiding this comment.
@michaelrsweet I have tested it locally, and --without-ondemand worked as I expected - there was no IdleExitTimeout line in cupsd.conf.
Tbh I would not leave any comment about IdleExitTimeout if ondemand is disabled - IMO person who builds CUPS without ondemand support on purpose won't be interested in a comment about ondemand specific conf directive. If you don't mind, I will only set EXIT_TIMEOUT to empty string, if with_ondemand = no for better code style and if on other archs/OS configure behaves differently.
zdohnal
force-pushed
the
idleexittimout-noondemand
branch
from
d008f7b to
cfeba38
Compare
There are distributions using CUPS without ondemand support, where IdleExitTimeout in cupsd.conf causes error in logs... Related OpenPrinting#1215
zdohnal
force-pushed
the
idleexittimout-noondemand
branch
from
e82dd6d to
e472e53
Compare
michaelrsweet
added
documentation
2 participants
There are distributions using CUPS without ondemand support, where IdleExitTimeout in cupsd.conf causes error in logs...
Related #1215