ppd-cache: fix memory leak#1344
Merged
michaelrsweet merged 1 commit intoOpenPrinting:masterfrom Aug 23, 2025
Merged
Conversation
These fields were being allocated by _ppdCacheCreateWith*() but never freed by anything. Free them in _ppdCacheDestroy() to fix the leak. Based on commit 7e4b961850b66baf895fc0 in libppd.
michaelrsweet
approved these changes
Aug 23, 2025
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Hmm, wonder why we missed this...
Contributor
Well done! How long have you used this software? How did you find this problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields were being allocated by _ppdCacheCreateWith*() but never freed by anything. Free them in _ppdCacheDestroy() to fix the leak.
Based on commit 7e4b961850b66baf895fc0 in libppd.