Fix backchannel status checking bugs#528
Merged
michaelrsweet merged 1 commit intoOpenPrinting:masterfrom Jan 30, 2023
Merged
Conversation
Contributor
Author
|
@zdohnal @michaelrsweet Please take a look at this and tell me if this if correct or the way it was before is intentional, considering the way I changed it to is written in the cupsBackChannelWrite function |
Member
|
@AtariDreams I'm swamped for the next couple weeks, so it will be a while before I can look at this and make sure there are no regressions. |
LumioseSil
force-pushed
the
backchannel
branch
4 times, most recently
from
f1f1800 to
594b9d6
Compare
LumioseSil
force-pushed
the
backchannel
branch
5 times, most recently
from
372437d to
71ff7d9
Compare
Checking for merely (status < 0) is a bug because the check for timeout is deliberate. Note that you have an if (timeout < 0) at the beginning So if the timeout is set to a value, it should check for that value. Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
LumioseSil
force-pushed
the
backchannel
branch
from
71ff7d9 to
178f07d
Compare
Contributor
Author
|
@michaelrsweet Could you please take a look at this |
michaelrsweet
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for merely (status < 0) is a bug because the check for timeout is deliberate.
Note that you have an if (timeout < 0) at the beginning
So if the timeout is set to a value, it should check for that value.
Co-Authored-By: aaaaaa123456789 aaaaaa123456789@acidch.at