Skip to content

Rework dependencies handling and switch from Flot library to Chart.js#96

Merged
PunkPun merged 3 commits intoOpenRA:masterfrom
KroArtem:akr/rework-dependencies-handling
Apr 30, 2026
Merged

Rework dependencies handling and switch from Flot library to Chart.js#96
PunkPun merged 3 commits intoOpenRA:masterfrom
KroArtem:akr/rework-dependencies-handling

Conversation

@KroArtem
Copy link
Copy Markdown
Contributor

@KroArtem KroArtem commented Mar 9, 2026

Closes #69 #93 #92 #75

As a followup of the issue with using AI to make changes, I've extracted useful commits from my work.

  • Most of the dependencies are now taken from CDN and are not stored in repository.

  • Dependencies were updated

  • After the update some issues arised with plots. The best way was to use some maintained library (last news from Flot library are from 2018 https://www.flotcharts.org/blog/), Chart.js was chosen.

Player activity plot before:

image

Player activity after changing to Chart.js

image

KroArtem added 3 commits March 9, 2026 17:01
dm-checkpoint-id: 3VVVTm2VadPi
(cherry picked from commit 9b96f28)
use chart.js instead of flot
Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait.

The newer chart is better.

I assume jsdelivr is just used to serve NPM? As the openra website does a lot of idling, can we rely on jsdelivr to always serve correctly? Or should we have backups just in case. This website doesn't really have any monitoring to notify us incase anything breaks with the CDN

@KroArtem
Copy link
Copy Markdown
Contributor Author

As I see it, jsdelivr is a CDN for openra website usecase.

Based on wikipedia,

JSDelivr (stylized as jsDelivr) is a public content delivery network for open-source software projects,
including packages hosted on GitHub, npm and WordPress.org
...
jsDelivr is powered by other content delivery network providers, including Cloudflare, Fastly
and BunnyCDN, and switches to another provider if one is experiencing downtime

There are some aggregators that show companies using jsdelivr but I think it's mostly advertising. So this CDN is not better or not worse than anything else, IMO.

Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@PunkPun PunkPun merged commit 647f36c into OpenRA:master Apr 30, 2026
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Apr 30, 2026

@KroArtem
Copy link
Copy Markdown
Contributor Author

KroArtem commented May 1, 2026

I saw that you've already fixed the deployment action, thanks. It slipped because I was not able to dry-run this action.
Build website step could be a part of a PR quality gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Games page has javascript errors

2 participants