Rework dependencies handling and switch from Flot library to Chart.js#96
Conversation
dm-checkpoint-id: 3VVVTm2VadPi (cherry picked from commit 9b96f28)
use chart.js instead of flot
…as eliminated from the repository
There was a problem hiding this comment.
Sorry for the long wait.
The newer chart is better.
I assume jsdelivr is just used to serve NPM? As the openra website does a lot of idling, can we rely on jsdelivr to always serve correctly? Or should we have backups just in case. This website doesn't really have any monitoring to notify us incase anything breaks with the CDN
|
As I see it, jsdelivr is a CDN for openra website usecase. Based on wikipedia, There are some aggregators that show companies using jsdelivr but I think it's mostly advertising. So this CDN is not better or not worse than anything else, IMO. |
|
Looks like website failed to deploy https://github.com/OpenRA/OpenRAWebsiteV3/actions/runs/25178050499/job/73815470218 |
|
I saw that you've already fixed the deployment action, thanks. It slipped because I was not able to dry-run this action. |
Closes #69 #93 #92 #75
As a followup of the issue with using AI to make changes, I've extracted useful commits from my work.
Most of the dependencies are now taken from CDN and are not stored in repository.
Dependencies were updated
After the update some issues arised with plots. The best way was to use some maintained library (last news from Flot library are from 2018 https://www.flotcharts.org/blog/), Chart.js was chosen.
Player activity plot before:
Player activity after changing to Chart.js