test: add example corpus non-vacuity guard - #709
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds an explicit non-vacuity guard to the SDL example scenario loading suite so a stale or relocated example-corpus root fails loudly instead of collecting zero parametrized cases.
Requirement UIDs
ASR-504Related Issues
Closes #7
ADR Impact
Changes
test_example_scenario_corpus_is_nonemptybeside the example scenario parametrization inimplementations/python/tests/test_scenarios.py.EXAMPLES_DIRandload_scenario()path unchanged.examples/scenarios/, so no documentation edit was needed.Test Plan
cd implementations/python && uv run --extra dev pytest tests/test_scenarios.py -q(27 passed)ACES_REQUIREMENT_UID=ASR-504 pre-commit run --all-filesACES_REQUIREMENT_UID=ASR-504 implementations/python/.venv/bin/python tools/check_repo_policy.pyACES_REQUIREMENT_UID=ASR-504 implementations/python/.venv/bin/python tools/check_requirement_governance.py(exited 0 with Ground Control unavailable skip)ACES_REQUIREMENT_UID=ASR-504 implementations/python/.venv/bin/python tools/verify_all.pyACES_REQUIREMENT_UID=ASR-504 uv tool run --from 'nox[uv]==2026.4.10' nox -f noxfile.py -s verifyThe full verify runs passed. Their requirement-governance subcheck also exited 0 in Ground Control unavailable skip mode.
Ground Control Checks
not_security_relevantgc_assert_quality_gatespassed forASR-504Traceability
Checklist
@Auditedon new entities if applicableDocumentation
Verified unchanged: no documentation update required for the test-only diff, and
docs/explain/sdl/testing.mdalready documents repo-rootexamples/scenarios/.