Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in land with construction rights in Six Flags over Texas and other parks #17774

Closed
Basssiiie opened this issue Aug 10, 2022 · 51 comments
Closed
Labels
bug Something went wrong.

Comments

@Basssiiie
Copy link
Member

Basssiiie commented Aug 10, 2022

Operating System

Windows 10, 64-bit

OpenRCT2 build

OpenRCT2, v0.4.1-159-g59c31e8 (59c31e8 on develop) provided by GitHub

Describe the issue

There are a few gaps in the area with construction rights in 'Six Flags over Texas', specifically under the parking lot next to the orange Titan coaster. Since similar issues in other base game parks were also fixed, I figured I'd report this one as well.

The same issue is also present in the empty 'Build your own Six Flags over Texas' park.

Area(s) with issue?

The bug also exists in RCT2 (vanilla)

Steps to reproduce

  1. Open 'Six Flags over Texas'.
  2. Select the park entrance.
  3. Hide paths and vegetation
  4. View the land rights next to the orange Titan coaster.

Attachments

With parking lot and vegetation hidden:
image

With nothing hidden:
image

@Basssiiie Basssiiie added the bug Something went wrong. label Aug 10, 2022
@Basssiiie
Copy link
Member Author

Another one in Urban Park (about halfway through the town, at x: 46, y: 47), which was mentioned on Discord a couple days ago, but hasn't gotten an issue yet:
image

Without anything hidden:
image

@Basssiiie Basssiiie changed the title Gaps in land with construction rights in Six Flags over Texas Gaps in land with construction rights in Six Flags over Texas and Urban Park Aug 10, 2022
@SpartanFrederic104
Copy link
Contributor

Doesn't this also happen in some of the RCT2 expansion scenarios (e.g. Mythological Madness)?

@Basssiiie
Copy link
Member Author

Basssiiie commented Aug 11, 2022

Yess you are right, there's two gaps in available land to buy on the small island left of the park entrance in Mythological Madness/Cradle of Civilization.
afbeelding

If you know any more, please share them :)

@Basssiiie Basssiiie changed the title Gaps in land with construction rights in Six Flags over Texas and Urban Park Gaps in land with construction rights in Six Flags over Texas and other parks Aug 11, 2022
@Basssiiie
Copy link
Member Author

Found another one in Robin Hood/Sherwood Forest.
afbeelding

@SpartanFrederic104
Copy link
Contributor

Rock ‘n’ Roll Revival 2022-08-11 10-58-54
Spotted one in Rock 'n' Roll Revival, in the large forest outside the starting park boundaries.
Schneider Shores 2022-08-11 11-01-24
A few construction rights tiles are also missing above the sea in Schneider Shores.
Rocky Rambles 2022-08-11 11-03-35
Rocky Rambles 2022-08-11 11-03-49
And wow there's quite a number of missing purchasable land tiles in Rocky Rambles. Good thing my Time Twister Redux scenario pack fixed these issues.
Rocky Rambles 2 2022-08-11 11-04-56
Rocky Rambles 2 2022-08-11 11-05-05

@733737
Copy link
Contributor

733737 commented Aug 21, 2022

how would the developers patch these scenarios? Does anybody currently plan on implementing fixes for these issues? I know they patched a scenario that had a water coaster vehicle bug

@Basssiiie
Copy link
Member Author

@733737 there are already land ownership fixes for RCT2's "European Culture Festival", "Extreme Hawaiian Island" implemented here and for various RCT1 scenario's here. This should be an easy issue any beginner could pick up. :)

@Basssiiie
Copy link
Member Author

Found 2 more issues in Schneider Cup:
image

The right one (the bush) cannot be bought at all while the left one can be bought as construction rights but that seems to be a mistake since the rest of the map is split between buyable = land, construction rights = water.

@SpartanFrederic104
Copy link
Contributor

Sherwood Forest 2022-09-04 10-28-45
Found yet another one in Sherwood Forest.

@SpartanFrederic104
Copy link
Contributor

SpartanFrederic104 commented Sep 7, 2022

Great Wall of China 2 2022-09-07 09-24-22
Asia - Great Wall of China Tourism Enhancement (Great Wall of China) has tile [127, 31] as a purchasable land tile. It should be land owned by park since money is disabled in that scenario anyway.

@Basssiiie
Copy link
Member Author

Another one in Utopia Park (Added Attractions/Corkscrew Follies), originally reported on Reddit.

image

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 11, 2022

Another one in the back of Katies Dreamland, where the underground coaster is (Followed through on a mention on Reddit as well.)

image

@Gymnasiast Gymnasiast self-assigned this Sep 11, 2022
@Basssiiie
Copy link
Member Author

Another one reported in the same Reddit thread; in the Grand Canyon scenario (Wacky Worlds), there are some tiles in the water near the map's edge that cannot be bought for construction rights.

Reported positions are: Tiles x131 y90, x132 y90, x133 y91, x134 y91, x135 y91, x136 y91, but there is a second group further up the river which is also circled here:

image

Original image from Reddit:
image

@Basssiiie
Copy link
Member Author

And two more tiles at where the river splits in two:

image

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 12, 2022

Might as well write a plugin script to find these. 😛

Two groups of three and one more here:

image

One more here at the river split:

image

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 12, 2022

South America - Incan Lost City (Wacky Worlds), these should all be construction rights owned.

Near the entrance:

image

Near the peep spawn:

image

In the corner with the temple of the golden llamas:

image

@Basssiiie
Copy link
Member Author

Maharaja Palace (Wacky Worlds), these should all be for sale.

On the right side of the palace:

image

Underwater, near the little island:

image

Four groups in the center of the river, right behind the palace:

image

@Basssiiie
Copy link
Member Author

Asia - Japanese Coastal Reclaim (Wacky Worlds)

One tile one the left side near the bullet train coaster, on the cliff edge, should be owned construction rights:

image

One tile on the right side in the centre of the temple, should be construction rights for sale:

image

On the biggest of the two small islands, there's four spots that should either be construction rights for sale (left three spots), or land for sale (rightmost spot):

image

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 12, 2022

Antartica - Ecological Salvage (Wacky Worlds)

One single tile in the water near the igloos and the stairs down to the water, should be for sale:

image

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 12, 2022

Mythological - Animatronic Film Set (Time Twister)

Three tiles in the canyon in the middle of the map, next to the station of the Harpies Rollercoaster, these should be owned construction rights:

image

@Basssiiie
Copy link
Member Author

Prehistoric - Jurassic Safari (Time Twister)

In the canyon, right under the Pterodactyl Terror flying rollercoaster, this tile should be construction rights:

image

@Basssiiie
Copy link
Member Author

Roaring Twenties - Schneider Cup (Time Twister) has a bunch more...

Right next to the biggest of the two cruise liners, 3 tiles split in two groups, should be construction rights for sale:

image

Five tiles at the tip of the island closest to the biggest cruise liner, should be construction rights for sale (but note that it's right next to land for sale):

image

Two groups, left one with 2 tiles and right one with 4 tiles, next to the starting point for the race, should be construction rights for sale:

image

@Basssiiie
Copy link
Member Author

Two more tiles in Rock 'n Roll - Rock 'n Roll that should be for sale:

One is next to the small waterfall and the Jet Plane Coaster:

image

The other one is in the far corner of the map in the forest:

image

@SpartanFrederic104
Copy link
Contributor

Quite a number of them in Six Flags Magic Mountain (I will give out the coordinates in [x, y] format):
Six Flags Magic Mountain 2022-09-12 11-00-53
[104, 190], [105, 190], [108, 197]

Six Flags Magic Mountain 2022-09-12 11-00-58
[75, 167]

Six Flags Magic Mountain 2022-09-12 11-01-14
[61, 92-95], [62, 90-94]

Six Flags Magic Mountain 2022-09-12 11-01-59
[92-93, 57], [89, 40-42], [90, 42]

Six Flags Magic Mountain 2022-09-12 11-02-03
[168-169, 20]

@SpartanFrederic104
Copy link
Contributor

Six Flags Holland:
Six Flags Holland 2022-09-12 11-05-58
[112, 33-34]

Six Flags Holland 2022-09-12 11-08-57
[113-117, 117], [114-117, 118]

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 12, 2022

Six Flags Holland, 9 tiles in the river in the far corner of the map near Goliath, these should be for sale:

image

Two tiles near Robin Hood should be for sale as well:

image

Edit: ah they were just reported 2 seconds ago 😛

@733737
Copy link
Contributor

733737 commented Sep 13, 2022

if there is a guide on how to patch these scenarios I guarantee I willl patch them all and submit a PR within a week. Right now I don't know how, but I would gladly put the time and effort if I did

@Basssiiie
Copy link
Member Author

Basssiiie commented Sep 13, 2022

@733737 You can look at how this PR was done for inspiration, maybe it helps: #15156 For RCT1 scenarios you'd have to do similar changes to this file.

@733737
Copy link
Contributor

733737 commented Sep 14, 2022

If Gymnasiast has been assigned to this then I am giving up on fixing it, I'll wait for Gymnasiast to do it, even if it takes a long time

@733737
Copy link
Contributor

733737 commented Sep 17, 2022

I think I fixed six flags holland import with my code, can somebody verify?
Six Flags Holland 2022-09-17 23-35-09

@733737
Copy link
Contributor

733737 commented Sep 18, 2022

I have a serious issue with implementing more fixes: #1 I need to know exact coordinates in x,y values for every park #2 I need to know if the issue is it should be owned, for sale, or contruction rights #3 I don't know how to implement construction rights as I only see OWNERSHIP_AVAILABLE and OWNERSHIP_OWNED in the code

@733737
Copy link
Contributor

733737 commented Sep 18, 2022

Mirage Madness 2022-09-12 11-16-47 Africa - Oasis (Mirage Madness) has a tile of construction rights at [61, 35] that should be land not owned by park.

Gymnasiast would have to fix this because I can't read his code to see if OWNERSHIP_UNOWNED is a thing

@Gymnasiast
Copy link
Member

Yes, OWNERSHIP_UNOWNED is a thing.

@Basssiiie
Copy link
Member Author

As mentioned before, I don't think there's any harm in leaving that in, and it's kinda funny. I'd say only fix the ones that can annoy people.

@Gymnasiast Gymnasiast removed their assignment Jan 24, 2023
@HtotheTML
Copy link
Contributor

image
Dark Age - Castle has park boundaries that make the path unusable here.

@HtotheTML
Copy link
Contributor

Six Flags Great Adventure contains a few stray owned tiles.
image

@HtotheTML
Copy link
Contributor

Africa - Oasis
image

@HtotheTML
Copy link
Contributor

HtotheTML commented Mar 15, 2023

pre-owned tiles in Ecological Salvage
image
image

@Basssiiie
Copy link
Member Author

@HtotheTML Some of these are not obstructing right? Just mistakes. I don't think they need fixing as they're just a funny quirk, not causing frustration.

@HtotheTML
Copy link
Contributor

image
Still an issue of land ownership, but this segment of prebuilt underground path in Cradle of Civilization is outside park boundaries even though it's meant to be inside the park.

@SpartanFrederic104
Copy link
Contributor

Is it actually purchasable land though?

@HtotheTML
Copy link
Contributor

that land is purchasable, yes, however that segment should be changed to already owned rather than for sale, or the path should be moved or changed.

@Basssiiie
Copy link
Member Author

What about having construction rights where the path is?

@HtotheTML
Copy link
Contributor

I think that would be reductive, since those tiles are normally purchasable land, along with most of the rest of the map.

@HtotheTML
Copy link
Contributor

I'm a bit unsure how to handle fixes other than making purchasable land for RCT1 scenarios, since the code formatting is different.

@Gymnasiast
Copy link
Member

Just call FixLandOwnershipTilesWithOwnership(tiles, OWNERSHIP_AVAILABLE); and replace OWNERSHIP_AVAILABLE with the correct ownership status.

HtotheTML added a commit to HtotheTML/OpenRCT2 that referenced this issue Mar 19, 2023
The issues in Katie's Dreamland, Utopia Park, Urban Park, Pleasure Island, and Fort Anachronism listed in issue OpenRCT2#17774 have been now dealt with.
@jglenn1562
Copy link

Dark Age Scenario Boundary Blocking Path

Dark Age - Another path that is blocked underground by park boundaries.

janisozaur added a commit that referenced this issue Dec 31, 2023
- Feature: [#12078] Add shortcut key for toggling wall slope.
- Feature: [#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [#20141] Add additional track pieces to the Giga Coaster.
- Feature: [#20825] Made setting the game speed a game action.
- Feature: [#20830] Display author field on scenery window.
- Feature: [#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [#20790] Default ride price set to free if park charges for entry.
- Change: [#20880] Restore removed default coaster colours.
- Change: [#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [#5677] Balloons pass through the ground and objects.
- Fix: [#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [#13473] Guests complain that the default Circus price is too high.
- Fix: [#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [#18199] Dots in the game save’s name no longer get truncated.
- Fix: [#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [#20356] Cannot set tertiary colour on small scenery.
- Fix: [#20624] Scrolling text glitches after language is changed.
- Fix: [#20679] Android: game crashes at launch.
- Fix: [#20737] Spent money in player window underflows when getting refunds.
- Fix: [#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [#20807] Tertiary colour not copied with small scenery.
- Fix: [#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
KatieZeldaKat pushed a commit to KatieZeldaKat/OpenRCT2 that referenced this issue Jan 2, 2024
- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope.
- Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster.
- Feature: [OpenRCT2#20825] Made setting the game speed a game action.
- Feature: [OpenRCT2#20830] Display author field on scenery window.
- Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry.
- Change: [OpenRCT2#20880] Restore removed default coaster colours.
- Change: [OpenRCT2#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [OpenRCT2#5677] Balloons pass through the ground and objects.
- Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high.
- Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated.
- Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery.
- Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed.
- Fix: [OpenRCT2#20679] Android: game crashes at launch.
- Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds.
- Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery.
- Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
CorySanin added a commit to CorySanin/OpenRCT2 that referenced this issue Feb 4, 2024
Release v0.4.7

- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope.
- Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster.
- Feature: [OpenRCT2#20825] Made setting the game speed a game action.
- Feature: [OpenRCT2#20830] Display author field on scenery window.
- Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry.
- Change: [OpenRCT2#20880] Restore removed default coaster colours.
- Change: [OpenRCT2#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [OpenRCT2#5677] Balloons pass through the ground and objects.
- Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high.
- Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated.
- Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery.
- Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed.
- Fix: [OpenRCT2#20679] Android: game crashes at launch.
- Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds.
- Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery.
- Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

6 participants