-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Forbid tree removal" restriction doesn't forbid removal of large scenery tree items #19722
Comments
Im looking into fixing this but I'm not sure how to reproduce the tree removal restriction? Do you have to already have a scenario with it and open that file or is there an easier way to recreate this? |
Its in the scenario options. |
Have a look at L79 of SmallSceneryRemoveAction.cpp you'll need to make the same code in LargeSceneryRemoveAction.cpp |
I appreciate your help but I still can't find it unfortunately |
OpenRCT2/src/openrct2/actions/SmallSceneryRemoveAction.cpp Lines 79 to 88 in 470d025
|
… tree removal Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
Previously only small trees were prevented from being removed in scenarios with the "forbid tree removal" flag. This change expands this behavior to similarly prevent large trees from being removed.
- Feature: [#12078] Add shortcut key for toggling wall slope. - Feature: [#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [#20141] Add additional track pieces to the Giga Coaster. - Feature: [#20825] Made setting the game speed a game action. - Feature: [#20830] Display author field on scenery window. - Feature: [#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [#20790] Default ride price set to free if park charges for entry. - Change: [#20880] Restore removed default coaster colours. - Change: [#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [#5677] Balloons pass through the ground and objects. - Fix: [#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [#13473] Guests complain that the default Circus price is too high. - Fix: [#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [#18199] Dots in the game save’s name no longer get truncated. - Fix: [#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [#20356] Cannot set tertiary colour on small scenery. - Fix: [#20624] Scrolling text glitches after language is changed. - Fix: [#20679] Android: game crashes at launch. - Fix: [#20737] Spent money in player window underflows when getting refunds. - Fix: [#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [#20807] Tertiary colour not copied with small scenery. - Fix: [#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope. - Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster. - Feature: [OpenRCT2#20825] Made setting the game speed a game action. - Feature: [OpenRCT2#20830] Display author field on scenery window. - Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry. - Change: [OpenRCT2#20880] Restore removed default coaster colours. - Change: [OpenRCT2#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [OpenRCT2#5677] Balloons pass through the ground and objects. - Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high. - Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated. - Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery. - Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed. - Fix: [OpenRCT2#20679] Android: game crashes at launch. - Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds. - Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery. - Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Release v0.4.7 - Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope. - Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster. - Feature: [OpenRCT2#20825] Made setting the game speed a game action. - Feature: [OpenRCT2#20830] Display author field on scenery window. - Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry. - Change: [OpenRCT2#20880] Restore removed default coaster colours. - Change: [OpenRCT2#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [OpenRCT2#5677] Balloons pass through the ground and objects. - Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high. - Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated. - Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery. - Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed. - Fix: [OpenRCT2#20679] Android: game crashes at launch. - Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds. - Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery. - Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Operating System
Windows 10
OpenRCT2 build
OpenRCT v0.4.3
Base game
RollerCoaster Tycoon 2
Area(s) with this issue?
The bug also exists in the original game (RCT2/RCTC)
Describe the issue
In RCT2 vanilla the 'forbid tree removal' restriction was implemented wonky and just disabled removing any small scenery item taller than about 4 units.
This was mostly fixed years ago, but you can still remove any trees that are larger than 1x1 tile, aka large tree scenery items.
Steps to reproduce
Open a scenario with the tree removal restriction.
Build a large tree scenery item.
Try to remove it.
Attachments
No response
The text was updated successfully, but these errors were encountered: