Save gamefile's name with many dots is truncated when it is saved

[telk5093]

Operating System

Windows 10, 64 bits

OpenRCT2 build

OpenRCT2, v0.4.2-3-g47d0402 (47d0402 on develop) provided by GitHub

Describe the issue

Saving the park with named many dots, such as Some park name v1.1, then it truncates the last term after the last dot and hence saved as Some park name v1.
I'm guessing the game confuses it is an extension.

Area(s) with issue?

New Save Format (NSF)

Steps to reproduce

1. Save park as Some park name v1.1
2. Check that the park is saved as Some park name v1

Attachments

[CookiePLMonster]

How does it behave when you use a system file browser? Is it same or does it work properly then?

[telk5093]

How does it behave when you use a system file browser? Is it same or does it work properly then?

It is fine when I use system file browser.

[beam41]

The save logic just replace last dot without checking, thinking it was extension
It should be like system file browser -> if extension match last dot do nothing if not just append extension to the file.
Can I work on this ? Seem like no one has working on it.

[CookiePLMonster]

It should be like system file browser -> if extension match last dot do nothing if not just append extension to the file.

Yeah, that sounds like the best way. Just be mindful of cases where multiple extensions are "valid" - I'm not sure if there are any cases like this in the codebase, though.

[beam41]

we only have .park for game save and .td6 for track save I think

Btw, I found out there are check for this bug in system file browser

OpenRCT2/src/openrct2-ui/windows/LoadSave.cpp

Lines 427 to 434 in 7e653fc

	u8string outPath = ContextOpenCommonFileDialog(desc);
	if (!outPath.empty())
	{
	// When the given save type was given, Windows still interprets a filename with a dot in its name as a custom extension,
	// meaning files like "My Coaster v1.2" will not get the .td6 extension by default.
	if (isSave && get_file_extension_type(outPath) != fileType)
	outPath = Path::WithExtension(outPath, extension);
	}

I will try to mimic this check.

[CookiePLMonster]

I'm not sure the system file browser bug is still valid after #18250.

[beam41]

Well, from my test, system file browser append extension correctly on its own, this line might not be important anymore, but I'm only tested on my win11 pc.

[CookiePLMonster]

I think the save dialog also needs "All Files" removed - there is no point in letting the user save the park with a custom extension if it's to be rejected further down the line anyway.

[beam41]

@CookiePLMonster I'd like to create another pull request for removing "All Files" but I'm not sure this logic can be remove too

OpenRCT2/src/openrct2-ui/windows/LoadSave.cpp

Lines 427 to 434 in 7e653fc

	u8string outPath = ContextOpenCommonFileDialog(desc);
	if (!outPath.empty())
	{
	// When the given save type was given, Windows still interprets a filename with a dot in its name as a custom extension,
	// meaning files like "My Coaster v1.2" will not get the .td6 extension by default.
	if (isSave && get_file_extension_type(outPath) != fileType)
	outPath = Path::WithExtension(outPath, extension);
	}

I know in windows it fine, but I don't have linux machine.

[CookiePLMonster]

It probably can, considering the fact comments specifically mention Windows. You might want to wait until someone from the dev team doublechecks though.

[CookiePLMonster]

Any update on this?

[beam41]

I have made a pull request. That should work with the current version but I'm busy now so you can take over.