-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tile inspector visibility hotkey does not use a game action #16453
Comments
@fidwell I am unable to reproduce this issue using the steps you provided. Do you still experience this issue, and if so, can you please provide additional information? |
Yes, I'm still experiencing this issue. I can reproducing it by connecting in my gigapark (admittedly not always the best place to test bugs?). It's a headless server running in a Docker container, if that makes any difference. It's currently running on version 435c38b. In this area on the right, I made this section of path invisible with the tile inspector, disconnected, and reconnected. When I reconnected, the path was visible again. Waiting for an autosave to trigger didn't make a difference. I understand this isn't really any more information, but I'm not sure what else you'd need to reproduce. |
I've noticed this is still happening, but have learned that it is only when you use a hotkey to make things invisible. Clicking the eye icon works as intended. |
I briefly looked into it, I think its bypassing game actions to do this which means you are doing this only locally and not on the server which also will result in a desync. |
I noticed replays also don't pick up on tile inspector action to make things invisible when done through hotkeys - which makes sense since the replays read game actions. |
The current way the hot key works for this is a bit hacky and has to be refactored, the hotkey should be directly tied to the tile inspector window as it also requires the selected index in order to work, its probably best done by using the window intent system which also needs some overhaul. The best case is that a window simply subscribes to an specific event and when the intent is send to the UI system it will invoke all subscribed functions, there is a big switch that manually deals with this per window basis. |
Fix #16453: Tile inspector invisibility shortcut does not use a game action
- Feature: [#12078] Add shortcut key for toggling wall slope. - Feature: [#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [#20141] Add additional track pieces to the Giga Coaster. - Feature: [#20825] Made setting the game speed a game action. - Feature: [#20830] Display author field on scenery window. - Feature: [#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [#20790] Default ride price set to free if park charges for entry. - Change: [#20880] Restore removed default coaster colours. - Change: [#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [#5677] Balloons pass through the ground and objects. - Fix: [#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [#13473] Guests complain that the default Circus price is too high. - Fix: [#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [#18199] Dots in the game save’s name no longer get truncated. - Fix: [#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [#20356] Cannot set tertiary colour on small scenery. - Fix: [#20624] Scrolling text glitches after language is changed. - Fix: [#20679] Android: game crashes at launch. - Fix: [#20737] Spent money in player window underflows when getting refunds. - Fix: [#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [#20807] Tertiary colour not copied with small scenery. - Fix: [#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope. - Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster. - Feature: [OpenRCT2#20825] Made setting the game speed a game action. - Feature: [OpenRCT2#20830] Display author field on scenery window. - Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry. - Change: [OpenRCT2#20880] Restore removed default coaster colours. - Change: [OpenRCT2#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [OpenRCT2#5677] Balloons pass through the ground and objects. - Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high. - Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated. - Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery. - Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed. - Fix: [OpenRCT2#20679] Android: game crashes at launch. - Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds. - Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery. - Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Release v0.4.7 - Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope. - Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types. - Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster. - Feature: [OpenRCT2#20825] Made setting the game speed a game action. - Feature: [OpenRCT2#20830] Display author field on scenery window. - Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file. - Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails. - Feature: [OpenMusic#46] Added Mystic ride music style. - Feature: [OpenMusic#50] Added Rock style 4 ride music. - Improved: [objects#261] Add composer credits on all RCT2 music objects. - Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry. - Change: [OpenRCT2#20880] Restore removed default coaster colours. - Change: [OpenRCT2#21102] The money effect will now update even when the game is paused. - Change: [objects#244] Update sort priorities for expansion scenery groups. - Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork. - Fix: [OpenRCT2#5677] Balloons pass through the ground and objects. - Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat. - Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high. - Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL. - Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action. - Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked. - Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios. - Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated. - Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items. - Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop. - Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery. - Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed. - Fix: [OpenRCT2#20679] Android: game crashes at launch. - Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds. - Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed. - Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions. - Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery. - Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists. - Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL. - Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks. - Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1. - Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Operating System
Windows 10, 64-bit
OpenRCT2 build
OpenRCT2, v0.3.5.1 (730364d on develop) provided by GitHub
Still occurring in 0.4.4.
Describe the issue
When using a hotkey to make an object visible or invisible in the tile inspector, it does not use a game action. This means that in multiplayer, when connected as a client, the host and other players will not see the invisibility toggled. It also will not persist in replays.
Area(s) with issue?
New Save Format (NSF)
Steps to reproduce
Persistence: Server-side
Persistence: Client-side
The text was updated successfully, but these errors were encountered: