Restore removed coaster colour presets

[ZeeMaji]

Restores some default coaster colour presets from vanilla RCT2 that were removed in #20119, going by the comment from gymnasiast there it seems like these were not intended to be removed and the discussion in #20311 suggests they shouldn't have been removed.

A few of these are similar to some of the new color presets added to the same ride types (the ones i've highlighted with purple tiles in the screenshot below) but i've included them anyways for now.

This also removes some colors from the inverted impulse coaster that were accidentally copied from the inverted hairpin coaster in #11987

[SpartanFrederic104]

Wasn't there also another track color preset for the Inverted Impulse Coaster from RCT2 vanilla that got removed too? If I remember correctly, it consisted of bright purple track and bordeaux red supports.

[ZeeMaji]

Wasn't there also another track color preset for the Inverted Impulse Coaster from RCT2 vanilla that got removed too? If I remember correctly, it consisted of bright purple track and bordeaux red supports.

I just went by what was removed in #20119, however if you can confirm that this is a colour preset in vanilla then i can go ahead and add it to this PR.

[ZeeMaji]

I just checked for my self in RCT classic and this indeed appears to be a color that was missed somehow, how interesting. I wonder how that happened? I'll work on adding it to this PR shortly.

[ZeeMaji]

There also appears to have been a red and yellow one that was missing too! I'll add these as well.

[ZeeMaji]

Hmm this is strange, it appears the following colors were accidentally added to the inverted impulse coaster in #11987 which replaced the original colors, as you can see by looking in ridedata.cpp in that PR (ctrl + f impulse) and comparing it to the impulse metadata file.

    { COLOUR_BRIGHT_YELLOW, COLOUR_BRIGHT_YELLOW, COLOUR_BRIGHT_RED },
    { COLOUR_BLACK, COLOUR_ICY_BLUE, COLOUR_BLACK },
    { COLOUR_WHITE, COLOUR_WHITE, COLOUR_YELLOW },

It seems as though these colors were accidentally copied from the inverted hairpin coaster to the inverted impulse coaster during #11987 and left the original colors from vanilla lost.

Since this definitely appears to be a mistake i will remove the hairpin colors from the impulse coaster

[tupaschoal]

Thoughts @karst and @Gymnasiast ?

[karst]

Per my statement on #20311 I removed them initially at keeping the coats of paint fresh, there were some subjectively ugly paints that we voted out. If people really miss them I don't mind getting them back in.

[ZeeMaji]

While i was initially creating this PR i got some generally positive thoughts in the discord from a few people. so there are a few other people who miss them.

[Gymnasiast]

I remember the discussion about the colour schemes revealing that what I considered ugly-as-hell styles were liked by others. As such, I think keeping the old ugly ones and just adding to them (what this PR is about) is, on balance, probably better.

I agree the Inverted Impulse schemes are probably a mistake - frutiemax and I created those styles essentially by just manually copying things over, so it’s not surprising the occasional mistake slipped in.

I hope that answers all outstanding questions here (as the conversation is quite long) - if I left anything unclear please say so.

[tupaschoal]

It does, thanks @Gymnasiast . @ZeeMaji would you please rebase it so we can merge it, then?

[ZeeMaji]

Hopefully that did the trick, it's been a long while since i last did this.