Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly hired staff does not have the correct speed set when speed is not default (normal) #20747

Closed
KawkMob opened this issue Aug 28, 2023 · 2 comments
Closed

Newly hired staff does not have the correct speed set when speed is not default (normal) #20747

KawkMob opened this issue Aug 28, 2023 · 2 comments
Assignees
@KawkMob
Labels
bug Something went wrong.

Comments

@KawkMob
Copy link
Contributor

KawkMob commented Aug 28, 2023

Operating System

Ubuntu 20.04

OpenRCT2 build

OpenRCT2, v0.4.5-271 (fa3339b on develop, DEBUG)

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

No response

Describe the issue

When hiring new staff, that staff does not follow the speed set in the Cheats menu.

See #20734 for discussion.

Implement a proper cheet getter on the OpenRCT2/src/openrct2/Cheats.cpp level.

Steps to reproduce

  1. Open cheat menu
  2. Navigate to "Park Cheats" tab
  3. Modify the "Staff speed" option to "Fast" or "Frozen" (from its default state of "Normal")
  4. Close the cheat menu
  5. Hire a new member of staff
  6. The new member of staff behaves as if "Staff speed" was set to "Normal" instead of what was set

Attachments

No response
@KawkMob KawkMob added the bug Something went wrong. label Aug 28, 2023
@KawkMob
Copy link
Contributor Author

KawkMob commented Aug 28, 2023

Please assign the issue to me

KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Aug 30, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin/apply f…
c98ded4 
…or new staff
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Aug 31, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin/apply f…
f06008e 
…or new staff
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Aug 31, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin/apply f…
2782ee1 
…or new staff
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Aug 31, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin/apply f…
1f251fe 
…or new staff
@KawkMob
Copy link
Contributor Author

KawkMob commented Sep 1, 2023

This is pretty much done now and makes #20581 deprecated.

KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Sep 3, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin/apply f…
1746596 
…or new staff
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Sep 4, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin
5355ef1
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Sep 8, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serializatin
4517676
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Sep 8, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
56a6459
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 5, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
f8ccf29
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 5, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
52e6283
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 13, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
a97df8a
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 16, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
ef2c5f2
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 16, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
d5d0dc2
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 20, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
620e414
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 20, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
72eec08
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 20, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
4ee920c
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 20, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
148a81d
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 20, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
c12b517
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 22, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
b7c8eb9
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 22, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
06c4aa0
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 23, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
5c630cd
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Oct 24, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
84cc476
KawkMob added a commit to KawkMob/OpenRCT2 that referenced this issue Nov 8, 2023
@KawkMob
Fix OpenRCT2#20747 handle staff speed permanency/serialization
4a801b9
janisozaur added a commit that referenced this issue Dec 31, 2023
@janisozaur
Release v0.4.7
0e8d46e 
- Feature: [#12078] Add shortcut key for toggling wall slope.
- Feature: [#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [#20141] Add additional track pieces to the Giga Coaster.
- Feature: [#20825] Made setting the game speed a game action.
- Feature: [#20830] Display author field on scenery window.
- Feature: [#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [#20790] Default ride price set to free if park charges for entry.
- Change: [#20880] Restore removed default coaster colours.
- Change: [#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [#5677] Balloons pass through the ground and objects.
- Fix: [#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [#13473] Guests complain that the default Circus price is too high.
- Fix: [#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [#18199] Dots in the game save’s name no longer get truncated.
- Fix: [#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [#20356] Cannot set tertiary colour on small scenery.
- Fix: [#20624] Scrolling text glitches after language is changed.
- Fix: [#20679] Android: game crashes at launch.
- Fix: [#20737] Spent money in player window underflows when getting refunds.
- Fix: [#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [#20807] Tertiary colour not copied with small scenery.
- Fix: [#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
KatieZeldaKat pushed a commit to KatieZeldaKat/OpenRCT2 that referenced this issue Jan 2, 2024
@janisozaur @KatieZeldaKat
Release v0.4.7
0d6724f 
- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope.
- Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster.
- Feature: [OpenRCT2#20825] Made setting the game speed a game action.
- Feature: [OpenRCT2#20830] Display author field on scenery window.
- Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry.
- Change: [OpenRCT2#20880] Restore removed default coaster colours.
- Change: [OpenRCT2#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [OpenRCT2#5677] Balloons pass through the ground and objects.
- Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high.
- Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated.
- Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery.
- Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed.
- Fix: [OpenRCT2#20679] Android: game crashes at launch.
- Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds.
- Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery.
- Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
CorySanin added a commit to CorySanin/OpenRCT2 that referenced this issue Feb 4, 2024
@CorySanin
Merge OpenRCT2 v0.4.7 into saveprep
f2bddfc 
Release v0.4.7

- Feature: [OpenRCT2#12078] Add shortcut key for toggling wall slope.
- Feature: [OpenRCT2#19919] Add diagonal brakes and diagonal block brakes to most coaster types.
- Feature: [OpenRCT2#20141] Add additional track pieces to the Giga Coaster.
- Feature: [OpenRCT2#20825] Made setting the game speed a game action.
- Feature: [OpenRCT2#20830] Display author field on scenery window.
- Feature: [OpenRCT2#20853] [Plugin] Add “BaseTileElement.owner” which is saved in the park file.
- Feature: [objects#257] Re-introduce the RCT1 road, which does not have handrails.
- Feature: [OpenMusic#46] Added Mystic ride music style.
- Feature: [OpenMusic#50] Added Rock style 4 ride music.
- Improved: [objects#261] Add composer credits on all RCT2 music objects.
- Change: [OpenRCT2#20790] Default ride price set to free if park charges for entry.
- Change: [OpenRCT2#20880] Restore removed default coaster colours.
- Change: [OpenRCT2#21102] The money effect will now update even when the game is paused.
- Change: [objects#244] Update sort priorities for expansion scenery groups.
- Change: [objects#256] Use recoloured RCT2 artwork on the Fruity Ices Stall, rather than the (slightly different) RCT1 artwork.
- Fix: [OpenRCT2#5677] Balloons pass through the ground and objects.
- Fix: [OpenRCT2#12299] Placing ride entrances/exits ignores the Disable Clearance Checks cheat.
- Fix: [OpenRCT2#13473] Guests complain that the default Circus price is too high.
- Fix: [OpenRCT2#15293] TTF fonts don’t format correctly with OpenGL.
- Fix: [OpenRCT2#16453] Tile inspector invisibility shortcut does not use a game action.
- Fix: [OpenRCT2#16926] When multiple vehicles are grouped in research, only one of them is unlocked.
- Fix: [OpenRCT2#17774] Misplaced/missing land and construction rights tiles in RCT1 & RCT2 scenarios.
- Fix: [OpenRCT2#18199] Dots in the game save’s name no longer get truncated.
- Fix: [OpenRCT2#19722] “Forbid tree removal” restriction doesn’t forbid removal of large scenery tree items.
- Fix: [OpenRCT2#20253] Crash when displaying a Lay-Down RC’s half loop.
- Fix: [OpenRCT2#20356] Cannot set tertiary colour on small scenery.
- Fix: [OpenRCT2#20624] Scrolling text glitches after language is changed.
- Fix: [OpenRCT2#20679] Android: game crashes at launch.
- Fix: [OpenRCT2#20737] Spent money in player window underflows when getting refunds.
- Fix: [OpenRCT2#20747] Staff speed cheat not applying to newly hired staff, UI not showing the current applied speed.
- Fix: [OpenRCT2#20778] [Plugin] Incorrect target api when executing custom actions.
- Fix: [OpenRCT2#20807] Tertiary colour not copied with small scenery.
- Fix: [OpenRCT2#20964] Crash when player connects to server with a group assigned that no longer exists.
- Fix: [OpenRCT2#20995] TTF fonts don’t support hinting, outlines, or insets with OpenGL.
- Fix: [OpenRCT2#21042] Peeps don’t render properly in S4 parks.
- Fix: [objects#246, objects#248] Some objects are incorrectly marked as originating from RCT1.
- Fix: [objects#260] Submarine Ride has its capacity listed incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KawkMob KawkMob

Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KawkMob