[Plugin] Fix incorrect target api when executing custom actions

[Basssiiie]

Hello,

This fixes an issue where plugins that use the deprecated custom actions API would get incorrect parameters, because the target api check would return an incorrect version on subsequent calls. Only the first query callback would be executed in the correct context.

This issue would break plugins expecting the parameters from the deprecated API, such as Spacek's MapMover

Plugin snippet to reproduce the issue:

registerPlugin({
	name: 'Test custom action',
	version: '1',
	authors: ['Basssiiie'],
	type: 'remote',
	licence: 'MIT',
	main() {		
		context.registerAction("test.action",
			function(args)
			{
				console.log("callback.query: " + JSON.stringify(args));
				return {};
			},
			function(args)
			{
				console.log("callback.execute: " + JSON.stringify(args));
				return {};
			}
		);
		
		ui.registerMenuItem("Call custom action", function()
		{
			context.executeAction("test.action", { myvalue: "hello world" });
		});
	},
});

Preferred and expected output:

'callback.query: {"myvalue":"hello world"}'
'callback.query: {"myvalue":"hello world"}'
'callback.execute: {"myvalue":"hello world"}'

Problematic output:

'callback.query: {"myvalue":"hello world"}'
'callback.query: {"action":"test.action","args":{"myvalue":"hello world"},"player":-1,"type":80,"isClientOnly":false}'
'callback.execute: {"action":"test.action","args":{"myvalue":"hello world"},"player":-1,"type":80,"isClientOnly":false}

Where the first call is using the old API_VERSION_68_CUSTOM_ACTION_ARGS and the second and third are using the newest API.

The fix was to replace the target API check that gets the target via the scripting engine context, with a check that checks directly with the custom action owner.

I have also quickly tested if any other users of GetTargetApiVersion() were affected, but they seem to be fine and always executed within valid a plugin context.

Thank you for your time.

[duncanspumpkin]

You'll need to update the changelog the change is under the wrong version.

[Basssiiie]

You'll need to update the changelog the change is under the wrong version.

Oh dammit. I'll blame it on the time, it was late. 😅 It should be correct now.