Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RCT1) Urban Park Entrance Problem #5905

Closed
TheLarry98 opened this issue Jul 15, 2017 · 3 comments
Closed

(RCT1) Urban Park Entrance Problem #5905

TheLarry98 opened this issue Jul 15, 2017 · 3 comments
Assignees
Labels
data file bug Misbehavior on interaction with data file.

Comments

@TheLarry98
Copy link

There is a Problem in the Urban Park from Added Attractions. The entrance and exit are switched, so the queue line goes away from the exit, instead of to the entrance.
This happens since Chris Sawyer made a mistake when he builds the park. (so also in RCT1).
screenshot_12

I don't know if it would be possible to fix this, without changing the SC4 file. (Similar to the missing land purchases)

@IntelOrca IntelOrca added the data file bug Misbehavior on interaction with data file. label Jul 15, 2017
@rwjuk
Copy link
Contributor

rwjuk commented Jul 15, 2017

We could swap the entrance and exit in the same way we patch up un-purchaseable land tiles.

@IntelOrca IntelOrca added the good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. label Jul 15, 2017
@CharlesLove
Copy link
Contributor

CharlesLove commented Jul 16, 2017

// Station
        dst->overall_view = src->overall_view;
        for (sint32 i = 0; i < RCT12_MAX_STATIONS_PER_RIDE; i++)
        {
            dst->station_starts[i] = src->station_starts[i];
            dst->station_heights[i] = src->station_height[i] / 2;
            dst->station_length[i] = src->station_length[i];
            dst->station_depart[i] = src->station_light[i];

            dst->train_at_station[i] = src->station_depart[i];

			if (_s4.scenario_slot_index == SC_URBAN_PARK) {
				if (src->entrance[0] == 25141) // Ride 1
				{
					dst->entrances[i] = src->exit[i];
					dst->exits[i] = src->entrance[i];
				}
				if (src->entrance[0] == 24621) // Ride 2
				{
					dst->entrances[i] = src->exit[i];
					dst->exits[i] = src->entrance[i];
				}
			}
			else
			{
				dst->entrances[i] = src->entrance[i];
				dst->exits[i] = src->exit[i];
			}
            
            dst->queue_time[i] = src->queue_time[i];
            dst->last_peep_in_queue[i] = src->last_peep_in_queue[i];
            dst->queue_length[i] = src->num_peeps_in_queue[i];
        }

        dst->num_stations = src->num_stations;

I've tried swapping ride exit and entrances in S4Importer.cpp in the ImportRide function, it doesn't seem to do anything, however. I'm likely not modifying the correct thing.

@Gymnasiast Gymnasiast removed the good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. label Jul 16, 2017
@Gymnasiast
Copy link
Member

@CharlesLove You need to modify both the Ride struct (like you did) and the actual map element.

@Gymnasiast Gymnasiast self-assigned this Jan 28, 2019
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 27, 2019
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 27, 2019
joshtucker132 pushed a commit to Nazey/Team-10-OpenRCT2 that referenced this issue Apr 8, 2019
AaronVanGeffen added a commit that referenced this issue Jul 10, 2019
- Feature: [#485] Rides can now be simulated with ghost trains during construction.
- Feature: [#1260] Option for making giant screenshots have a transparent background.
- Feature: [#2339] Find local servers automatically when fetching servers.
- Feature: [#7296] Allow assigning a keyboard shortcut for the scenery picker.
- Feature: [#8029] Add the Hungarian Forint (HUF) to the list of available currencies.
- Feature: [#8481] Multi-threaded rendering.
- Feature: [#8558] Guest debugging tab.
- Feature: [#8659] Banner and sign texts are now shown in tooltips.
- Feature: [#8687] New multiplayer toolbar icon showing network status with reconnect option.
- Feature: [#8791] Improved tile element flag manipulation in Tile Inspector.
- Feature: [#8919] Allow setting ride price from console.
- Feature: [#8963] Add missing Czech letters to sprite font, use sprite font for Czech.
- Feature: [#9154] Change map toolbar icon with current viewport rotation.
- Change: [#7877] Files are now sorted in logical rather than dictionary order.
- Change: [#8427] Ghost elements now show up as white on the mini-map.
- Change: [#8688] Move common actions from debug menu into cheats menu.
- Change: [#9428] Increase maximum height of the Hypercoaster to RCT1 limits.
- Fix: [#2294] Clients crashing the server with invalid object selection.
- Fix: [#4568, #5896] Incorrect fences removed when building a tracked ride through
- Fix: [#5103] OpenGL: ride track preview not rendered.
- Fix: [#5889] Giant screenshot does not work while using OpenGL renderer.
- Fix: [#5579] Network desync immediately after connecting.
- Fix: [#5893] Looking at guest window tabs other than the main tab eventually causes assertion.
- Fix: [#5905] Urban Park merry-go-round has entrance and exit swapped (original bug).
- Fix: [#6006] Objects higher than 6 metres are considered trees (original bug).
- Fix: [#7039] Map window not rendering properly when using OpenGL.
- Fix: [#7045] Theme window's colour pickers not drawn properly on OpenGL.
- Fix: [#7323] Tunnel entrances not rendering in 'highlight path issues' mode if they have benches inside.
- Fix: [#7729] Money Input Prompt breaks on certain values.
- Fix: [#7884] Unfinished preserved rides can be demolished with quick demolish.
- Fix: [#7913] RCT1/RCT2 title sequence timing is off.
- Fix: [#7700, #8079, #8969] Crash when unloading buggy custom rides.
- Fix: [#7829] Rotated information kiosk can cause 'unreachable' messages.
- Fix: [#7878] Scroll shortcut keys ignore SHIFT/CTRL/ALT modifiers.
- Fix: [#8219] Faulty folder recreation in "save" folder.
- Fix: [#8480, #8535] Crash when mirroring track design.
- Fix: [#8507] Incorrect change in vehicle rolling direction.
- Fix: [#8537] Imported RCT1 rides/shops are all numbered 1.
- Fix: [#8553] Scenery removal tool removes fences and paths while paused.
- Fix: [#8598] Taking screenshots fails with some park names.
- Fix: [#8602] Wall piece collision detection deviates from vanilla
- Fix: [#8649] Setting date does not work in multiplayer.
- Fix: [#8873] Potential crash when placing footpaths.
- Fix: [#8882] Submarine Ride does not count as indoors (original bug).
- Fix: [#8900] Peep tracking is not synchronized.
- Fix: [#8909] Potential crash when invoking game actions as server.
- Fix: [#8947] Detection of AVX2 support.
- Fix: [#8988] Character sprite lookup noticeably slows down drawing.
- Fix: [#9000] Show correct error message if not enough money available.
- Fix: [#9067] Land/water tools show prices when money is disabled.
- Fix: [#9124] Disconnected clients can crash the server.
- Fix: [#9132] System file browser cannot open SV4 files.
- Fix: [#9152] Spectators can modify ride colours.
- Fix: [#9202] Artefacts show when changing ride type as client or using in-game console.
- Fix: [#9240] Crash when passing directory instead of save file.
- Fix: [#9245] Headless servers apply Discord Rich Presence.
- Fix: [#9293] Issue with the native load/save dialog.
- Fix: [#9322] Peep crashing the game trying to find a ride to look at.
- Fix: [#9324] Crash trying to remove invalid footpath scenery.
- Fix: [#9402] Ad campaigns disappear when you save and load the game.
- Fix: [#9411] Ad campaigns end too soon.
- Fix: [#9476] Running `simulate` command on park yields `Completed: (null)`.
- Fix: [#9520] Time Twister object artdec29 conversion problem.
- Fix: Guests eating popcorn are drawn as if they're eating pizza.
- Fix: The arbitrary ride type and vehicle dropdown lists are ordered case-sensitively.
- Improved: [#6116] Expose colour scheme for track elements in the tile inspector.
- Improved: Allow the use of numpad enter key for console and chat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data file bug Misbehavior on interaction with data file.
Projects
None yet
Development

No branches or pull requests

5 participants