Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCT1 title sequence timing is off #7913

Closed
jensj12 opened this issue Aug 19, 2018 · 6 comments
Closed

RCT1 title sequence timing is off #7913

jensj12 opened this issue Aug 19, 2018 · 6 comments
Assignees
@Gymnasiast
Labels
investigate Not sure what the problem is yet.

Comments

@jensj12
Copy link
Contributor

jensj12 commented Aug 19, 2018

OS: Windows 10
Version: 0.2.0-316
Commit/Build: ea8bab9

The RCT1 title sequences stay longer at the same screen than in the original game (or physics are very different, but that's unlikely). This is especially notable on Diamond Heights, Karts & Coasters and Three Monkeys Park, where coaster trains are already (almost) gone when the screen is focused on them.

Steps to reproduce:

  1. Set title sequence to one from RCT1
  2. Go to main menu and watch
@AaronVanGeffen AaronVanGeffen added the investigate Not sure what the problem is yet. label Aug 19, 2018
@AaronVanGeffen
Copy link
Member

This is just speculation, but think this could have been introduced when we changed the wait times to milliseconds.

@Gymnasiast
Copy link
Member

Which RCT1 scenarios are you using? SC4 ones or Crappage's recreations?

@jensj12
Copy link
Contributor Author

jensj12 commented Aug 20, 2018

I use the SC4 ones from the steam edition of RCT Deluxe.

@Gymnasiast
Copy link
Member

It might have been caused by OpenRCT2/title-sequences#1, which multiplied all intervals by 8000, expect for the original RCT1 and RCT2 ones.

If it turns out to be caused by that, it would be a good moment to replace the LOADRCT1 commands as well.

@AaronVanGeffen
Copy link
Member

AaronVanGeffen commented Aug 20, 2018 •
edited
Loading

It might have been caused by OpenRCT2/title-sequences#1, which multiplied all intervals by 8000, expect for the original RCT1 and RCT2 ones.

The PR you're linking was updating the timing for the original sequences, by a factor 1000. One was forgotten, which has been addressed...

If it turns out to be caused by that, it would be a good moment to replace the LOADRCT1 commands as well.

I'd like to see that go, too, yeah…

@Gymnasiast
Copy link
Member

It updated the custom sequences by multiplying by 800, though. I think it should have done the same with the original ones.

@Gymnasiast Gymnasiast self-assigned this Jan 28, 2019
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 27, 2019
@Gymnasiast
Fix OpenRCT2#7913: RCT1/RCT2 title sequence timing is off
0174988
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 27, 2019
@Gymnasiast
Fix OpenRCT2#7913: RCT1/RCT2 title sequence timing is off
8c95584
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 27, 2019
@Gymnasiast
Fix OpenRCT2#7913: RCT1/RCT2 title sequence timing is off
2ae8595
joshtucker132 pushed a commit to Nazey/Team-10-OpenRCT2 that referenced this issue Apr 8, 2019
@Gymnasiast
Fix OpenRCT2#7913: RCT1/RCT2 title sequence timing is off (OpenRCT2#8980
fe5fba0 
)
AaronVanGeffen added a commit that referenced this issue Jul 10, 2019
@AaronVanGeffen
Release v0.2.3.
ac7a1eb 
- Feature: [#485] Rides can now be simulated with ghost trains during construction.
- Feature: [#1260] Option for making giant screenshots have a transparent background.
- Feature: [#2339] Find local servers automatically when fetching servers.
- Feature: [#7296] Allow assigning a keyboard shortcut for the scenery picker.
- Feature: [#8029] Add the Hungarian Forint (HUF) to the list of available currencies.
- Feature: [#8481] Multi-threaded rendering.
- Feature: [#8558] Guest debugging tab.
- Feature: [#8659] Banner and sign texts are now shown in tooltips.
- Feature: [#8687] New multiplayer toolbar icon showing network status with reconnect option.
- Feature: [#8791] Improved tile element flag manipulation in Tile Inspector.
- Feature: [#8919] Allow setting ride price from console.
- Feature: [#8963] Add missing Czech letters to sprite font, use sprite font for Czech.
- Feature: [#9154] Change map toolbar icon with current viewport rotation.
- Change: [#7877] Files are now sorted in logical rather than dictionary order.
- Change: [#8427] Ghost elements now show up as white on the mini-map.
- Change: [#8688] Move common actions from debug menu into cheats menu.
- Change: [#9428] Increase maximum height of the Hypercoaster to RCT1 limits.
- Fix: [#2294] Clients crashing the server with invalid object selection.
- Fix: [#4568, #5896] Incorrect fences removed when building a tracked ride through
- Fix: [#5103] OpenGL: ride track preview not rendered.
- Fix: [#5889] Giant screenshot does not work while using OpenGL renderer.
- Fix: [#5579] Network desync immediately after connecting.
- Fix: [#5893] Looking at guest window tabs other than the main tab eventually causes assertion.
- Fix: [#5905] Urban Park merry-go-round has entrance and exit swapped (original bug).
- Fix: [#6006] Objects higher than 6 metres are considered trees (original bug).
- Fix: [#7039] Map window not rendering properly when using OpenGL.
- Fix: [#7045] Theme window's colour pickers not drawn properly on OpenGL.
- Fix: [#7323] Tunnel entrances not rendering in 'highlight path issues' mode if they have benches inside.
- Fix: [#7729] Money Input Prompt breaks on certain values.
- Fix: [#7884] Unfinished preserved rides can be demolished with quick demolish.
- Fix: [#7913] RCT1/RCT2 title sequence timing is off.
- Fix: [#7700, #8079, #8969] Crash when unloading buggy custom rides.
- Fix: [#7829] Rotated information kiosk can cause 'unreachable' messages.
- Fix: [#7878] Scroll shortcut keys ignore SHIFT/CTRL/ALT modifiers.
- Fix: [#8219] Faulty folder recreation in "save" folder.
- Fix: [#8480, #8535] Crash when mirroring track design.
- Fix: [#8507] Incorrect change in vehicle rolling direction.
- Fix: [#8537] Imported RCT1 rides/shops are all numbered 1.
- Fix: [#8553] Scenery removal tool removes fences and paths while paused.
- Fix: [#8598] Taking screenshots fails with some park names.
- Fix: [#8602] Wall piece collision detection deviates from vanilla
- Fix: [#8649] Setting date does not work in multiplayer.
- Fix: [#8873] Potential crash when placing footpaths.
- Fix: [#8882] Submarine Ride does not count as indoors (original bug).
- Fix: [#8900] Peep tracking is not synchronized.
- Fix: [#8909] Potential crash when invoking game actions as server.
- Fix: [#8947] Detection of AVX2 support.
- Fix: [#8988] Character sprite lookup noticeably slows down drawing.
- Fix: [#9000] Show correct error message if not enough money available.
- Fix: [#9067] Land/water tools show prices when money is disabled.
- Fix: [#9124] Disconnected clients can crash the server.
- Fix: [#9132] System file browser cannot open SV4 files.
- Fix: [#9152] Spectators can modify ride colours.
- Fix: [#9202] Artefacts show when changing ride type as client or using in-game console.
- Fix: [#9240] Crash when passing directory instead of save file.
- Fix: [#9245] Headless servers apply Discord Rich Presence.
- Fix: [#9293] Issue with the native load/save dialog.
- Fix: [#9322] Peep crashing the game trying to find a ride to look at.
- Fix: [#9324] Crash trying to remove invalid footpath scenery.
- Fix: [#9402] Ad campaigns disappear when you save and load the game.
- Fix: [#9411] Ad campaigns end too soon.
- Fix: [#9476] Running `simulate` command on park yields `Completed: (null)`.
- Fix: [#9520] Time Twister object artdec29 conversion problem.
- Fix: Guests eating popcorn are drawn as if they're eating pizza.
- Fix: The arbitrary ride type and vehicle dropdown lists are ordered case-sensitively.
- Improved: [#6116] Expose colour scheme for track elements in the tile inspector.
- Improved: Allow the use of numpad enter key for console and chat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gymnasiast Gymnasiast

Labels
investigate Not sure what the problem is yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AaronVanGeffen @Gymnasiast @jensj12