Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ride The ZAP! crashes when unloading passengers #8079

Closed
tombomp opened this issue Oct 10, 2018 · 1 comment
Closed

Custom ride The ZAP! crashes when unloading passengers #8079

tombomp opened this issue Oct 10, 2018 · 1 comment
Labels
crash Game exits suddenly.

Comments

@tombomp
Copy link
Contributor

tombomp commented Oct 10, 2018

OS: [e.g. Windows 10]
Version: 0.2.1
Commit/Build: 426e106

https://openrct2.org/forums/topic/3415-game-crashes-when-there-are-over-2000-guests-in-park/ If you download the save "Mystic Timbers" in the last post of this thread and open it up, it crashes within 1 second when the custom ride The ZAP! unloads. This isn't specific to the save, if you try and create it in a different map the same happens. I assume this ride worked for someone at sometime as otherwise it wouldn't have been uploaded (although maybe i'm wrong - I don't have vanilla around to test)

Stack trace:
openrct2.dll!std::vector<signed char,std::allocator >::operator[](const unsigned __int64 _Pos) Line 1733 C++
openrct2.dll!rct_peep::UpdateRideLeaveVehicle() Line 4092 C++
openrct2.dll!rct_peep::UpdateRide() Line 5065 C++
openrct2.dll!rct_peep::Update() Line 1267 C++
openrct2.dll!peep_update_all() Line 442 C++
openrct2.dll!OpenRCT2::GameState::UpdateLogic() Line 247 C++
openrct2.dll!OpenRCT2::GameState::Update() Line 141 C++
openrct2.dll!OpenRCT2::Context::Update() Line 940 C++
openrct2.dll!OpenRCT2::Context::RunFixedFrame() Line 858 C++
openrct2.dll!OpenRCT2::Context::RunFrame() Line 832 C++
openrct2.dll!OpenRCT2::Context::RunGameLoop() Line 802 C++
openrct2.dll!OpenRCT2::Context::Launch() Line 774 C++
openrct2.dll!OpenRCT2::Context::RunOpenRCT2(int argc, const char * * argv) Line 215 C++
openrct2.dll!NormalisedMain(int argc, const char * * argv) Line 60 C++
openrct2.dll!LaunchOpenRCT2(int argc, wchar_t * * argvW) Line 46 C++
openrct2.exe!wmain(int argc, wchar_t * * argvW, wchar_t * envp) Line 28 C++
[External Code]

The problem is vehicle_entry->peep_loading_positions is empty so vehicle_entry->peep_loading_positions[current_seat] throws an out of range error. I'm not sure how this happened as I don't understand structure of rides enough.

  • [] Reproducible in RCT2 (vanilla)?
  • [] Specific to multiplayer?

Steps to reproduce:

  1. Open attached save

  2. Crashes within 1 second, which is exactly when The ZAP! is unloading

Save game:

Mystic Timbers.zip

@tombomp tombomp changed the title Custom ride The ZZap! crashes whe Custom ride The ZZap! crashes when unloading passengers Oct 10, 2018
@tombomp tombomp changed the title Custom ride The ZZap! crashes when unloading passengers Custom ride The ZAP! crashes when unloading passengers Oct 10, 2018
@Broxzier Broxzier added the crash Game exits suddenly. label Oct 13, 2018
@tombomp
Copy link
Contributor Author

tombomp commented Oct 16, 2018

Going back through old issues turns out this has already been reported as #7700

Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Apr 20, 2019
duncanspumpkin added a commit that referenced this issue Apr 23, 2019
Fix #8079: Crash when unloading buggy custom rides
AaronVanGeffen added a commit that referenced this issue Jul 10, 2019
- Feature: [#485] Rides can now be simulated with ghost trains during construction.
- Feature: [#1260] Option for making giant screenshots have a transparent background.
- Feature: [#2339] Find local servers automatically when fetching servers.
- Feature: [#7296] Allow assigning a keyboard shortcut for the scenery picker.
- Feature: [#8029] Add the Hungarian Forint (HUF) to the list of available currencies.
- Feature: [#8481] Multi-threaded rendering.
- Feature: [#8558] Guest debugging tab.
- Feature: [#8659] Banner and sign texts are now shown in tooltips.
- Feature: [#8687] New multiplayer toolbar icon showing network status with reconnect option.
- Feature: [#8791] Improved tile element flag manipulation in Tile Inspector.
- Feature: [#8919] Allow setting ride price from console.
- Feature: [#8963] Add missing Czech letters to sprite font, use sprite font for Czech.
- Feature: [#9154] Change map toolbar icon with current viewport rotation.
- Change: [#7877] Files are now sorted in logical rather than dictionary order.
- Change: [#8427] Ghost elements now show up as white on the mini-map.
- Change: [#8688] Move common actions from debug menu into cheats menu.
- Change: [#9428] Increase maximum height of the Hypercoaster to RCT1 limits.
- Fix: [#2294] Clients crashing the server with invalid object selection.
- Fix: [#4568, #5896] Incorrect fences removed when building a tracked ride through
- Fix: [#5103] OpenGL: ride track preview not rendered.
- Fix: [#5889] Giant screenshot does not work while using OpenGL renderer.
- Fix: [#5579] Network desync immediately after connecting.
- Fix: [#5893] Looking at guest window tabs other than the main tab eventually causes assertion.
- Fix: [#5905] Urban Park merry-go-round has entrance and exit swapped (original bug).
- Fix: [#6006] Objects higher than 6 metres are considered trees (original bug).
- Fix: [#7039] Map window not rendering properly when using OpenGL.
- Fix: [#7045] Theme window's colour pickers not drawn properly on OpenGL.
- Fix: [#7323] Tunnel entrances not rendering in 'highlight path issues' mode if they have benches inside.
- Fix: [#7729] Money Input Prompt breaks on certain values.
- Fix: [#7884] Unfinished preserved rides can be demolished with quick demolish.
- Fix: [#7913] RCT1/RCT2 title sequence timing is off.
- Fix: [#7700, #8079, #8969] Crash when unloading buggy custom rides.
- Fix: [#7829] Rotated information kiosk can cause 'unreachable' messages.
- Fix: [#7878] Scroll shortcut keys ignore SHIFT/CTRL/ALT modifiers.
- Fix: [#8219] Faulty folder recreation in "save" folder.
- Fix: [#8480, #8535] Crash when mirroring track design.
- Fix: [#8507] Incorrect change in vehicle rolling direction.
- Fix: [#8537] Imported RCT1 rides/shops are all numbered 1.
- Fix: [#8553] Scenery removal tool removes fences and paths while paused.
- Fix: [#8598] Taking screenshots fails with some park names.
- Fix: [#8602] Wall piece collision detection deviates from vanilla
- Fix: [#8649] Setting date does not work in multiplayer.
- Fix: [#8873] Potential crash when placing footpaths.
- Fix: [#8882] Submarine Ride does not count as indoors (original bug).
- Fix: [#8900] Peep tracking is not synchronized.
- Fix: [#8909] Potential crash when invoking game actions as server.
- Fix: [#8947] Detection of AVX2 support.
- Fix: [#8988] Character sprite lookup noticeably slows down drawing.
- Fix: [#9000] Show correct error message if not enough money available.
- Fix: [#9067] Land/water tools show prices when money is disabled.
- Fix: [#9124] Disconnected clients can crash the server.
- Fix: [#9132] System file browser cannot open SV4 files.
- Fix: [#9152] Spectators can modify ride colours.
- Fix: [#9202] Artefacts show when changing ride type as client or using in-game console.
- Fix: [#9240] Crash when passing directory instead of save file.
- Fix: [#9245] Headless servers apply Discord Rich Presence.
- Fix: [#9293] Issue with the native load/save dialog.
- Fix: [#9322] Peep crashing the game trying to find a ride to look at.
- Fix: [#9324] Crash trying to remove invalid footpath scenery.
- Fix: [#9402] Ad campaigns disappear when you save and load the game.
- Fix: [#9411] Ad campaigns end too soon.
- Fix: [#9476] Running `simulate` command on park yields `Completed: (null)`.
- Fix: [#9520] Time Twister object artdec29 conversion problem.
- Fix: Guests eating popcorn are drawn as if they're eating pizza.
- Fix: The arbitrary ride type and vehicle dropdown lists are ordered case-sensitively.
- Improved: [#6116] Expose colour scheme for track elements in the tile inspector.
- Improved: Allow the use of numpad enter key for console and chat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Game exits suddenly.
Projects
None yet
Development

No branches or pull requests

2 participants