Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile Inspector Improvements #8791

Closed
duncanspumpkin opened this issue Feb 27, 2019 · 25 comments
Closed

Tile Inspector Improvements #8791

duncanspumpkin opened this issue Feb 27, 2019 · 25 comments
Assignees
Labels
feature Add something new to the game. regression An issue that was made since the last release.

Comments

@duncanspumpkin
Copy link
Contributor

duncanspumpkin commented Feb 27, 2019

After #8781 the tile inspector broken column is now a path only flag (it used to also show if a block brake was closed). It should be moved out of the column and into the group box.

In addition we should expose the BLOCK_BRAKE_CLOSED flag and the INDESTRUCTIBLE_TRACK_PIECE on the track group box. BLOCKED_BY_VEHICLE could also be exposed in the footpath group box but I think it gets reset possibly every tick so might not be useful.

@duncanspumpkin duncanspumpkin added feature Add something new to the game. regression An issue that was made since the last release. labels Feb 27, 2019
@Broxzier Broxzier self-assigned this Mar 7, 2019
@joshtucker132
Copy link
Contributor

@Broxzier Are you still working on this issue?

@Broxzier
Copy link
Member

@joshtucker132 I haven't started yet, feel free to work on it.

@joshtucker132
Copy link
Contributor

How do you access the group boxes?

@jmyre1999
Copy link

@Broxzier What are group boxes?

@duncanspumpkin
Copy link
Contributor Author

The group box is the tile type specific box at the bottom. Circled red

image

#8574 was a PR that added a new detail to a group box. It may give clues on how best to modify the window to add the required new detail.

@jmyre1999
Copy link

jmyre1999 commented Apr 17, 2019

How do I access the tile inspector? I thought it would be available but enabling debug tools but the button still isn't there.

Edit: Referring to the Cheat Options button

@jmyre1999
Copy link

Do you want the BLOCK_BRAKE_CLOSED flag and the INDESTRUCTIBLE_TRACK_PIECE to be put in the track details section of the group box?

@duncanspumpkin
Copy link
Contributor Author

Yes put both those in the group box

@jmyre1999
Copy link

I pretty much got it, just not sure about getting the proper string

@duncanspumpkin
Copy link
Contributor Author

Do you mean new strings? Feel free to make a draft PR if you want help.

@Broxzier
Copy link
Member

Broxzier commented Apr 22, 2019

@jmyre1999 I just made a similar change to the tile inspector, maybe this helps you find what you need: ac7bc97

Mainly the changes in en-GB.txt, StringIds.h and TileInspector.cpp.

@joshtucker132
Copy link
Contributor

Should the broken flag show up in the group box only if it evaluates to true?

@duncanspumpkin
Copy link
Contributor Author

Ideally have it the same as all of the other group box flags and make it clickable.

@joshtucker132
Copy link
Contributor

What do you mean by clickable? Nothing appears to happen when I click on any of the other flags. Do you mean make it a check box?

@duncanspumpkin
Copy link
Contributor Author

Yeah a check box.

@joshtucker132
Copy link
Contributor

Screen Shot 2019-04-23 at 12 14 51 PM

So something like this?

@jmyre1999
Copy link

@Broxzier Your commit you referenced me to was of great help, thank you

@duncanspumpkin Should BLOCK_BRAKE_CLOSED and INDESTRUCTIBLE_TRACK_PIECE be clickable as well?

@duncanspumpkin
Copy link
Contributor Author

Yes i think that would make sense. I'm not sure when the block brake one would be useful but no harm adding it

@joshtucker132
Copy link
Contributor

@duncanspumpkin I'm having trouble getting the checkbox to stay selected. If I hold down the mouse, a checkmark appears, but as soon as it is released the checkmark disappears and a small red line appears below the checkbox. Any advice on how to fix this issue? I tried to follow the implementation of the "sloped" flag. Is there another flag that is more comparable to the "broken" one?

@duncanspumpkin
Copy link
Contributor Author

Create a draft pr and we will be able to take a look. I'm not very knowledgeable on our windows so will need to see code.

@jmyre1999
Copy link

I believe I have gotten all functionality working properly, but I am having issues with my newly defined strings. For some reason, when I try to use them they instead result in {undefined string} rather than my defined values.
image
image
image
image

@duncanspumpkin
Copy link
Contributor Author

Do you symlink your data folders so that your language files are used when you run the game?

@jmyre1999
Copy link

That might be the problem. One of my team members ran my branch on their machine and did not have this issue.

Also, what is the block brake closed flag used for?

@duncanspumpkin
Copy link
Contributor Author

When a train is going around a continuous block brake circuit track it will need to close and open the block brake as it proceeds through each section.

@jmyre1999
Copy link

Ah I see, thanks!

joshtucker132 pushed a commit to Nazey/Team-10-OpenRCT2 that referenced this issue Apr 28, 2019
AaronVanGeffen added a commit that referenced this issue Jul 10, 2019
- Feature: [#485] Rides can now be simulated with ghost trains during construction.
- Feature: [#1260] Option for making giant screenshots have a transparent background.
- Feature: [#2339] Find local servers automatically when fetching servers.
- Feature: [#7296] Allow assigning a keyboard shortcut for the scenery picker.
- Feature: [#8029] Add the Hungarian Forint (HUF) to the list of available currencies.
- Feature: [#8481] Multi-threaded rendering.
- Feature: [#8558] Guest debugging tab.
- Feature: [#8659] Banner and sign texts are now shown in tooltips.
- Feature: [#8687] New multiplayer toolbar icon showing network status with reconnect option.
- Feature: [#8791] Improved tile element flag manipulation in Tile Inspector.
- Feature: [#8919] Allow setting ride price from console.
- Feature: [#8963] Add missing Czech letters to sprite font, use sprite font for Czech.
- Feature: [#9154] Change map toolbar icon with current viewport rotation.
- Change: [#7877] Files are now sorted in logical rather than dictionary order.
- Change: [#8427] Ghost elements now show up as white on the mini-map.
- Change: [#8688] Move common actions from debug menu into cheats menu.
- Change: [#9428] Increase maximum height of the Hypercoaster to RCT1 limits.
- Fix: [#2294] Clients crashing the server with invalid object selection.
- Fix: [#4568, #5896] Incorrect fences removed when building a tracked ride through
- Fix: [#5103] OpenGL: ride track preview not rendered.
- Fix: [#5889] Giant screenshot does not work while using OpenGL renderer.
- Fix: [#5579] Network desync immediately after connecting.
- Fix: [#5893] Looking at guest window tabs other than the main tab eventually causes assertion.
- Fix: [#5905] Urban Park merry-go-round has entrance and exit swapped (original bug).
- Fix: [#6006] Objects higher than 6 metres are considered trees (original bug).
- Fix: [#7039] Map window not rendering properly when using OpenGL.
- Fix: [#7045] Theme window's colour pickers not drawn properly on OpenGL.
- Fix: [#7323] Tunnel entrances not rendering in 'highlight path issues' mode if they have benches inside.
- Fix: [#7729] Money Input Prompt breaks on certain values.
- Fix: [#7884] Unfinished preserved rides can be demolished with quick demolish.
- Fix: [#7913] RCT1/RCT2 title sequence timing is off.
- Fix: [#7700, #8079, #8969] Crash when unloading buggy custom rides.
- Fix: [#7829] Rotated information kiosk can cause 'unreachable' messages.
- Fix: [#7878] Scroll shortcut keys ignore SHIFT/CTRL/ALT modifiers.
- Fix: [#8219] Faulty folder recreation in "save" folder.
- Fix: [#8480, #8535] Crash when mirroring track design.
- Fix: [#8507] Incorrect change in vehicle rolling direction.
- Fix: [#8537] Imported RCT1 rides/shops are all numbered 1.
- Fix: [#8553] Scenery removal tool removes fences and paths while paused.
- Fix: [#8598] Taking screenshots fails with some park names.
- Fix: [#8602] Wall piece collision detection deviates from vanilla
- Fix: [#8649] Setting date does not work in multiplayer.
- Fix: [#8873] Potential crash when placing footpaths.
- Fix: [#8882] Submarine Ride does not count as indoors (original bug).
- Fix: [#8900] Peep tracking is not synchronized.
- Fix: [#8909] Potential crash when invoking game actions as server.
- Fix: [#8947] Detection of AVX2 support.
- Fix: [#8988] Character sprite lookup noticeably slows down drawing.
- Fix: [#9000] Show correct error message if not enough money available.
- Fix: [#9067] Land/water tools show prices when money is disabled.
- Fix: [#9124] Disconnected clients can crash the server.
- Fix: [#9132] System file browser cannot open SV4 files.
- Fix: [#9152] Spectators can modify ride colours.
- Fix: [#9202] Artefacts show when changing ride type as client or using in-game console.
- Fix: [#9240] Crash when passing directory instead of save file.
- Fix: [#9245] Headless servers apply Discord Rich Presence.
- Fix: [#9293] Issue with the native load/save dialog.
- Fix: [#9322] Peep crashing the game trying to find a ride to look at.
- Fix: [#9324] Crash trying to remove invalid footpath scenery.
- Fix: [#9402] Ad campaigns disappear when you save and load the game.
- Fix: [#9411] Ad campaigns end too soon.
- Fix: [#9476] Running `simulate` command on park yields `Completed: (null)`.
- Fix: [#9520] Time Twister object artdec29 conversion problem.
- Fix: Guests eating popcorn are drawn as if they're eating pizza.
- Fix: The arbitrary ride type and vehicle dropdown lists are ordered case-sensitively.
- Improved: [#6116] Expose colour scheme for track elements in the tile inspector.
- Improved: Allow the use of numpad enter key for console and chat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add something new to the game. regression An issue that was made since the last release.
Projects
None yet
Development

No branches or pull requests

5 participants