Fix idle play squatting connection-slot exhaustion DoS - #207
Merged
Conversation
After the setup grace window, unpaused play sessions that never received any outbound relay (no publisher, no cache replay) are now closed like paused squatters. Players actively receiving relay remain protected. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
AlexanderWagnerDev
added a commit
that referenced
this pull request
Aug 10, 2026
…#208) Unpaused players with zero outbound relay are reaped after the setup grace window (PR #207). The deleteStream regression test must set media_bytes_sent so it exercises a legitimate viewer, not a squatter. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
AlexanderWagnerDev
marked this pull request as ready for review
August 10, 2026 10:00
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix
Severity: Medium
Location:
src/session/conn.rsIdle unpaused play sessions never reaped (connection-slot exhaustion DoS)
playon streams with no publisher; slow-reader teardown never runs because no relay data is sent.media_bytes_sent == 0. Players actively receiving relay remain protected.CI should run
cargo test(especiallysession_setup_timed_outand server poll reaper tests).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.