Fixed the memory usage display to show up correctly on project creation#5666
Merged
elebitzero merged 1 commit intoOpenRefine:masterfrom Mar 6, 2023
Merged
Conversation
github-actions
bot
added
the
Type: Bug
wetneb
approved these changes
Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5665
(Regression introduced by #5222 )
When I made an original change to make the memory% more accurate, it seemed to be working, but now it is broken, and parenthesis are required for the order of operations. Looks like it finally works as intended now since the memory% increases as more rows are read in. If you hit 100% on a large CSV file, the JVM will start thrashing and possibly get an OutOfMemory error.
Before:
After:
