Skip to content

Conversation

@DevangJagdale
Copy link
Contributor

@DevangJagdale DevangJagdale commented Sep 22, 2025

Fixes #7341

0922.mp4

@github-actions github-actions bot added the Type: Bug Issues related to software defects or unexpected behavior, which require resolution. label Sep 22, 2025
Copy link
Member

@tfmorris tfmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Because it addresses a critical data reliability area, we want to make sure it has excellent test coverage. Could you please add some tests?

Also, the original issue mentions issues with deserializing existing corrupted projects, which this doesn't seem to address.

@tfmorris
Copy link
Member

p.s. because this is likely a much bigger task than you anticipated, you are welcome to switch to a more manageable sized task, if that's your preference.

@tfmorris
Copy link
Member

Thanks for additional updates. I apologize for not noticing before that this PR was created from your master branch, but that's going to be very susceptible to inadvertent changes. Could you please move these to a feature branch and open a new PR based on that?

You can do that by something along the lines of

git remote update
git checkout master
git checkout -b 7341-column-name-escape

to create the new branch and then commit your changes to that, perhaps by using git cherry-pick (although you might want to use git rebase -i to squash some of the commits together so that you have fewer commits to cherry pick.

I will start my review in parallel with that process.

@DevangJagdale
Copy link
Contributor Author

#7461
use this PR instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to deserialize changes for column renaming operation

2 participants