Skip to content

refactor: Remove dead code and stale references #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louisgv merged 1 commit into from
Feb 27, 2026
Merged

refactor: Remove dead code and stale references #1987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sh/shared/github-auth.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ _install_gh_brew() {

# Install gh via APT with GitHub's official repository (Debian/Ubuntu)
_install_gh_apt() {
# Use sudo only when not already root (Fly.io containers run as root)
# Use sudo only when not already root (some cloud containers run as root)
local SUDO=""
if [[ "$(id -u)" -ne 0 ]]; then SUDO="sudo"; fi

Expand Down
4 changes: 2 additions & 2 deletions sh/shared/key-request.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ process.stdout.write(d[process.env._VAR] || d.api_key || d.token || '');
# downstream in unquoted expansions, eval contexts, or logging
# Allow alphanumeric plus safe chars needed by real tokens:
# - _ . / @ (standard API key chars)
# : + = (base64 segments, URL-style formats)
# space (Fly.io "FlyV1 <macaroon>" prefixed tokens)
# : + = (base64 segments, URL-safe and base64 formats)
# space (prefixed token formats, e.g., "Bearer <token>")
# Must match CLI's loadTokenFromConfig regex in cli/src/digitalocean/digitalocean.ts
if [[ ! "${val}" =~ ^[a-zA-Z0-9._/@:+=\ -]+$ ]]; then
log "SECURITY: Invalid characters in config value for ${var_name}"
Expand Down