fix(example): remove res.Data access in Example_listModels after pagination regen#352
Merged
Merged
Conversation
…nation regen The pagination regeneration removed .Data from the models list response. Update Example_listModels to only check res != nil instead of accessing the now-missing res.Data field, fixing the sdk-build-check (go) CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
sdk-build-check (go)CI failure blocking PR #27246.The pagination regeneration removed
.Datafrom the models list response type, butExample_listModelsinexample_test.gostill referencedres.Data, causing a build error.Change
example_test.go—Example_listModels:The other
res.Datareferences in the file (single-model fetch, providers list) are in different functions with different response types that still carry.Data— those are untouched.