Replace spin-polling with anyio.Event in ToolEventBroadcaster - #1
Closed
mattapperson wants to merge 1 commit into
Closed
Replace spin-polling with anyio.Event in ToolEventBroadcaster#1mattapperson wants to merge 1 commit into
mattapperson wants to merge 1 commit into
Conversation
The _BroadcastConsumer.__anext__ method was using await anyio.sleep(0.001) in a tight loop, burning CPU while waiting for new events. Replace this with an anyio.Event that is set on push() and complete(), so consumers block efficiently until signaled. The event is replaced after each set() to support repeated wake cycles. Adds concurrent producer/consumer tests to verify the event-driven behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
await anyio.sleep(0.001)spin-polling in_BroadcastConsumer.__anext__with properanyio.Eventsignalingpush()andcomplete()now set the event to wake blocked consumers immediatelyset()call to support repeated wake cycles (anyio events are single-use)Test plan
test_broadcaster_concurrent_push_and_consumeto verify event-driven wake under concurrent producer/consumertest_broadcaster_multiple_concurrent_consumersto verify multiple consumers wake correctly