Skip to content

perf: --single-branch upstream clone (follow-up to #19 review) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasParke merged 2 commits into from
Jul 29, 2026
Merged

perf: --single-branch upstream clone (follow-up to #19 review) #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81fec6
perf(upstream): clone upstream --single-branch, with a fetch fallback…
LukasParke Jul 28, 2026
7e51d31
fix(upstream): guard ref arguments against option injection
LukasParke Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/upstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,21 @@ if [ -d "$upstream_dir/.git" ]; then
git -C "$upstream_dir" fetch --tags --force origin
else
rm -rf "$upstream_dir"
git clone "$upstream_url" "$upstream_dir"
# --single-branch: CI recreates this clone every run, and fetching the whole
# ref namespace roughly doubles clone time for nothing — the script targets
# origin/HEAD or a release tag (reachable from the default branch, so still
# fetched). Refs outside that (e.g. a manual run against a feature branch)
# are handled by the fallback fetch below.
git clone --single-branch "$upstream_url" "$upstream_dir"
fi

if [ -n "$ref" ]; then
target_commit="$(git -C "$upstream_dir" rev-parse "$ref^{commit}")"
# --end-of-options / --: a ref value starting with "-" must not be parsed as
# an option (CI refs always start with "@", but manual runs take anything).
if ! target_commit="$(git -C "$upstream_dir" rev-parse --quiet --verify --end-of-options "$ref^{commit}")"; then
git -C "$upstream_dir" fetch origin -- "$ref"
target_commit="$(git -C "$upstream_dir" rev-parse FETCH_HEAD^{commit})"
fi
else
target_commit="$(git -C "$upstream_dir" rev-parse origin/HEAD 2>/dev/null || git -C "$upstream_dir" rev-parse origin/main)"
fi
Expand Down
Loading