Merge beta to 1.17.2 - #791
Merged
Merged
Conversation
docs: refresh screenshots (v1.17.1)
…sym is present GSAK's own GPX/GGZ export never sets sym="Geocache Found" (unlike the GC.com Pocket Query convention), so the #766 log-based found fallback — which only ran when <sym> was entirely absent — silently dropped found status from real GSAK exports. Detect genuine GSAK origin via GSAK-only wptExtension fields OpenSAK's own export never writes (UserFlag, FirstToFind, UserSort, IsPremium, UserData/User2-4, FavPoints, County, LatN/LongE, LatBeforeCorrect/LonBeforeCorrect) and allow the fallback to run in that case too. fixes #766
docs: refresh screenshots (v1.17.2-beta.1)
A real GSAK GPX export supplied by Allyn56 (GC4RD9A before/after pair, issue #766) showed GSAK's actual found-status convention is a trailing "|Found" segment on <type> (e.g. <type>Geocache|Traditional Cache|Found</type>) -- not sym="Geocache Found", and not necessarily a personal log entry either, since GSAK's Mark As Found doesn't always add one. - found_by_me is now also derived directly from the <type> "|Found" segment, independent of both <sym> and the log list - cache_type parsing strips that trailing segment first, so it can't be misparsed as the cache type itself - the found_date "oldest found-type log" fallback now only runs when neither gc_username nor gc_finder_id is configured, so a configured username that simply doesn't appear in this file's logs no longer gets a stranger's find date silently attributed to it Adds tests/unit-tests/test_gsak_found_status_import.py, extends tests/data.py's cache_wpt() with a type_found option.
docs: refresh screenshots (v1.17.2-beta.2)
QSizePolicy.Ignored (set in the #755 fix, v1.17.1) lacks the ExpandFlag that the tab widget's default Expanding policy carries, so the tabs stopped absorbing leftover vertical space in the panel's QVBoxLayout — Qt spread it across every row instead, including the header/meta rows. Replaced with a _TabWidget subclass overriding minimumSizeHint() to return QSize(0, 0), which keeps #755's fix (tab pages' minimum height no longer propagates up) without touching the size policy — tabs keep Expanding and their vertical stretch priority, as in v1.17.0. Bump version to 1.17.2-beta.3.
docs: refresh screenshots (v1.17.2-beta.3)
…tandard dialog buttons - da.py: import_geocode_running now says 'opdaterer' (matches English 'Looking up... (offline)') instead of the misleading 'geokoder' - de.py: fix 'einloogen' -> 'einloggen' and 'eingebn' -> 'eingeben' typos - app.py: install Qt's own qtbase_xx.qm translator at startup so QDialogButtonBox standard buttons (Close/OK/Cancel etc.) are also translated, not just OpenSAK's own tr() strings — this is why the Coordinate Converter's Close button stayed in English regardless of UI language - opensak.spec: bundle qtbase_*.qm for all 8 supported languages so the fix also works in packaged Windows/Linux/macOS builds
docs: refresh screenshots (v1.17.2-beta.4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.