Fix IsoApplet hard coded algorithm_ref#3632
Open
Disappear9 wants to merge 5 commits intoOpenSC:masterfrom
Open
Fix IsoApplet hard coded algorithm_ref#3632Disappear9 wants to merge 5 commits intoOpenSC:masterfrom
Disappear9 wants to merge 5 commits intoOpenSC:masterfrom
Conversation
Member
|
We have just the test with the 2k key. When we will get this fixed here an in the isoapplet repo, can you adjust also the following test line to generate the 4k key (or create another one): https://github.com/OpenSC/OpenSC/blob/master/.github/test-isoapplet.sh#L74 It will need adjustment of the reference json file. I will try to keep an eye on that, but please remind me if I will forget: https://github.com/OpenSC/OpenSC/blob/master/src/tests/p11test/isoapplet_ref_v1.json |
Jakuje
approved these changes
Apr 1, 2026
Author
|
Now we wait: philipWendland/IsoApplet#46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: philipWendland/IsoApplet#45
Tested on card: J3R180 with IsoApplet v1
opensc-tool -n
Checklist