Add signature AlgorithmIdentifier support - #670
Merged
Conversation
Add DER-encoded AlgorithmIdentifier support, including RSA-PSS parameters and correct default salt length handling. Also fix PSS salt length parsing and separate gettable/settable signature parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
Generating a certificate with a PKCS#11 private key fails during
AlgorithmIdentifierprocessing with ASN.1 errors:and eventually causes a segmentation fault.
New Behavior
Generating self-signed certificates and CSRs with PKCS#11-backed signing keys succeeds without ASN.1 errors or crashes, with a valid signature
AlgorithmIdentifierreturned by the provider.Scope of Changes
Add
OSSL_SIGNATURE_PARAM_ALGORITHM_IDsupport to the PKCS#11 provider.This includes:
AlgorithmIdentifiersRSA-PSSdefault salt lengthThis fixes certificate and CSR generation with provider-backed signing keys.
Testing
Additional Notes
License Declaration