Fix: perbaikan kerjasama#1637
Open
pandigresik wants to merge 4 commits into
Open
Conversation
Contributor
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix perbaikan pendaftaran kerjasama OpenDK
Depedency
https://github.com/OpenSID/Layanan_OpenDESA/pull/1235
Description
Perbaikan dan rebranding halaman pendaftaran kerjasama OpenDK. Mengubah terminologi dari "Kecamatan" sebagai penyelenggara menjadi "OpenDesa", memperbaiki kompatibilitas dengan Livewire v3, serta menyederhanakan alur pendaftaran. Juga memperbaiki auto-fill form dari data user dan mengganti mekanisme upload file agar kompatibel dengan Livewire v3.
Changes made:
$this->emit()ke$this->dispatch()— methodemit()sudah dihapus di Livewire v3$wirenot definedwire:model.lazydenganx-on:change="$wire.upload()"pada upload file — Alpinex-modeltidak support file input<div x-if>menjadi<template x-if>di check_connection — Alpine mengharuskanx-ifpada<template>value="{{ $property }}"pada inputwire:model— Livewire v3 tidak otomatis render value attributewire:loading.attr="disabled"dan spinner pada tombol Simpan — mencegah double-click dan memberi indikasi prosesstatus_langganan_idkestatus_langgaan_idsesuai respons APIReason for change:
livewire/livewire ^3.0tetapi kode masih menggunakan sintaks v2 (emit,wire:model.lazy, Alpine CDN terpisah) yang tidak kompatibelImpact of change:
✅ Livewire v3 Compatible: Semua komponen berfungsi dengan Livewire v3 tanpa error
✅ UX Improved: Auto-fill data user, loading state pada submit button
✅ Rebranding: Informasi dan dokumen kerjasama konsisten menggunakan "OpenDesa"
✅ Robustness: Tidak ada konflik Alpine, upload file berfungsi dengan $wire.upload()
✅ Testing: Smoke test diperbarui sesuai perubahan UI
Related Issue
#1632
Steps to Reproduce
Before fix (problem):
$this->emit()error karena Livewire v3$wireundefinedx-iferror pada<div>bukan<template>After fix (solution):
$wire.upload()memproses upload → button Simpan aktifTesting on related features:
Checklist
Technical Details
Technical Explanation
Livewire v3 Migration:
$this->emit('triggerAlert', ...)→$this->dispatch('triggerAlert', ...)— method emit dihapus di v3wire:model.lazytidak dikenal di v3 sehingga binding upload file tidak berfungsi → ganti dengan Alpinex-on:change+$wire.upload()wire:modeldi v3 tidak otomatis rendervalueattribute → tambah eksplisit di bladeAlpine.js:
@livewireScripts→ hapus CDN manualalpinejs@3.x.xx-ifhanya valid pada<template>→ perbaiki dicheck_connection.blade.phpUpload File:
Loading State:
Configuration changes
None
Dependencies added
None
Testing
Manual Testing
x-on:change+$wire.upload()Automated Testing
Breaking Changes
None
Migration Guide
Not required
Video
simplescreenrecorder-2026-07-10_13.22.54.mp4
References
Additional notes: Beberapa file juga mengalami pembersihan komentar/kosong (blank lines, comments) yang tidak perlu.