feat(skillmgr): register shop skills in KnownSkills (issue #142 fusion)#221
Merged
Conversation
What ships:
- cmd/sin-code/internal/skillmgr/manager.go — KnownSkills()
now includes the three shop skills (issue #142 acceptance
criterion #2: 'sin-code skills list shows the three shop
skills under their category'):
- shop-cj-dropshipping -> cj-dropshipping-skill
- shop-stripe -> SIN-Stripe-Bundle
- shop-tiktok -> SIN-eCommerce-Scraper-Bundle
- cmd/sin-code/internal/skillmgr/manager_test.go — new
TestKnownSkillsHasShopEntries that asserts the three
entries are present with the correct repo mapping
- CHANGELOG entry
What was already in place from PR #218 (issue #139):
- lifecycle: external frontmatter on the three SKILL.md files
- sources: frontmatter pointing to the canonical external repos
- context/, frameworks/, tasks/, templates/ directories
Long-term fusion strategy (per issue #142 body):
- Phase 1: external canonical (current state)
- Phase 2: bundled doc (done in PR #218)
- Phase 3: native subcommand (deferred until shop domain matures)
- Phase 4: deprecate upstream (after phase 3 is stable)
Refs: #142
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown)
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown) Run ID:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the registry half of issue #142 (the doc half was done in PR #218 / issue #139).
What ships
cmd/sin-code/internal/skillmgr/manager.go—KnownSkills()now includes the three shop skills:shop-cj-dropshipping→cj-dropshipping-skillshop-stripe→SIN-Stripe-Bundleshop-tiktok→SIN-eCommerce-Scraper-Bundlecmd/sin-code/internal/skillmgr/manager_test.go— newTestKnownSkillsHasShopEntriesasserts the three entriesWhat was already in place from PR #218 (issue #139)
lifecycle: externalfrontmatter on the three SKILL.md filessources:frontmatter pointing to the canonical external reposcontext/,frameworks/,tasks/,templates/directoriesvalidate_skill.py --all-bundled --strictpasses (0 failed for 34 skills)Long-term fusion strategy (per issue #142 body)
Diffstat
Closes