Skip to content

Phone Validation#848

Merged
gonzalesedwin1123 merged 17 commits into17.0from
phone-validity
Oct 2, 2025
Merged

Phone Validation#848
gonzalesedwin1123 merged 17 commits into17.0from
phone-validity

Conversation

@emjay0921
Copy link
Copy Markdown
Contributor

@emjay0921 emjay0921 commented Sep 30, 2025

Why is this change needed?

Add a way to have multiple accepted format on phone numbers

How was the change implemented?

Added a new configuration to be able to add different formats for phone, and use that as validation

New unit tests

spp_registry_base.TestPhoneValidation

Unit tests executed by the author

spp_registry_base.TestPhoneValidation

How to test manually

  • Install or Upgrade spp_registry_base
  • In the Registry > Configuration > Phone Validation, add phone formats
  • Try to create a phone on Group or Individuals with correct and incorrect phone numbers

Related links

@emjay0921 emjay0921 changed the title Phone validity Phone Validation Sep 30, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 92.43697% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.07%. Comparing base (f8a5832) to head (5c99104).
⚠️ Report is 41 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_base_common/models/phone_number.py 92.59% 1 Missing and 3 partials ⚠️
spp_base_common/models/phone_validation.py 81.81% 4 Missing ⚠️
..._base_common/tests/test_phone_number_validation.py 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #848      +/-   ##
==========================================
+ Coverage   77.98%   78.07%   +0.09%     
==========================================
  Files         768      771       +3     
  Lines       19962    20155     +193     
  Branches     2398     2436      +38     
==========================================
+ Hits        15568    15737     +169     
- Misses       3842     3851       +9     
- Partials      552      567      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review October 2, 2025 07:28
@emjay0921 emjay0921 removed the request for review from reichie020212 October 2, 2025 07:28
@gonzalesedwin1123 gonzalesedwin1123 merged commit 95434f7 into 17.0 Oct 2, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants