Skip to content

Phone Validation #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzalesedwin1123 merged 17 commits into from
Oct 2, 2025

[FIX] tests

5c99104
Select commit
Loading
Failed to load commit list.
Merged

Phone Validation #848

[FIX] tests
5c99104
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2025 in 0s

78.07% (+0.09%) compared to f8a5832

View this Pull Request on Codecov

78.07% (+0.09%) compared to f8a5832

Details

Codecov Report

❌ Patch coverage is 92.43697% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.07%. Comparing base (f8a5832) to head (5c99104).
⚠️ Report is 23 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_base_common/models/phone_number.py 92.59% 1 Missing and 3 partials ⚠️
spp_base_common/models/phone_validation.py 81.81% 4 Missing ⚠️
..._base_common/tests/test_phone_number_validation.py 97.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             17.0     #848      +/-   ##
==========================================
+ Coverage   77.98%   78.07%   +0.09%     
==========================================
  Files         768      771       +3     
  Lines       19962    20155     +193     
  Branches     2398     2436      +38     
==========================================
+ Hits        15568    15737     +169     
- Misses       3842     3851       +9     
- Partials      552      567      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov