Add cross-site footer links and rewrite logo to main site#19
Merged
Conversation
Shared overrides/ applies to both mkdocs.yml (docs.osc.earth) and mkdocs-courses.yml (courses.osc.earth). - main.html: extends base; inlines JS that rewrites header logo and site-title href to https://osc.earth on each instant-nav swap via Material's document$ observable; inlines footer link styles. - partials/copyright.html: adds three-site footer nav (osc.earth, docs.osc.earth, courses.osc.earth) above copyright and Material generator line.
- Replace logo-rewrite JS with Material's native extra.homepage config in both mkdocs.yml and mkdocs-courses.yml. Eliminates flash-of-wrong href on initial load and removes fragile DOM selectors. - Drop the custom libs block from main.html; only CSS remains. - Move md-copyright__highlight back to wrap the copyright text (matches Material default); drop the non-existent md-copyright__generator wrapper around the Made-with-Material line. - Wrap cross-site links in nav + ul/li with aria-label; separator now rendered via CSS ::before so screen readers see a clean list.
Member
Author
Review findings addressedRan Applied
Not applied (intentional)
Built both configs with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overrides/applied to both MkDocs configs (docs.osc.earth,courses.osc.earth).https://osc.earth(applied on each instant-nav swap via Material'sdocument$observable).osc.earth·docs.osc.earth·courses.osc.earth) above copyright and Material generator line.Files
overrides/main.html— extendsbase.html; inlines footer-link CSS (extrahead) and logo-rewrite JS (libs).overrides/partials/copyright.html— custom copyright partial with cross-site links.Test plan
uv run mkdocs buildpassesuv run mkdocs build -f mkdocs-courses.ymlpasseshref=https://*.osc.earthfooter links on both sitesmkdocs serveon both configs; click logo navigates toosc.earth; footer links render and work