Skip to content

Update OpenSecret SDK to 3.3.0#42

Merged
AnthonyRonning merged 2 commits into
masterfrom
codex-embeddings-api-investigation-maple-proxy
Jul 11, 2026
Merged

Update OpenSecret SDK to 3.3.0#42
AnthonyRonning merged 2 commits into
masterfrom
codex-embeddings-api-investigation-maple-proxy

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

Tinfoil and the OpenSecret backend already support encoding_format: "base64". Maple Proxy failed while the older SDK attempted to deserialize every embedding as Vec<f64>. OpenSecret SDK 3.3.0 models the response as either a float vector or base64 string, so Maple Proxy can preserve and return either wire representation without proxy-layer conversion logic.

Testing

  • confirmed opensecret 3.3.0 is published and downloadable from crates.io
  • cargo tree -i opensecret --locked resolves opensecret v3.3.0
  • nix develop -c just check
    • formatting passed
    • Clippy passed with warnings denied
    • 12 tests passed

Closes #40.


Open in Devin Review

Summary by CodeRabbit

  • Chores
    • Updated the OpenSecret library to version 3.3.0.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6b79952-5f36-4ea8-82fd-7a5cf8d4b76e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The project updates its opensecret dependency from version 3.1.1 to 3.3.0 in Cargo.toml.

Changes

OpenSecret dependency update

Layer / File(s) Summary
Update OpenSecret crate version
Cargo.toml
The opensecret dependency declaration changes from 3.1.1 to 3.3.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops through Cargo’s stream,
“Three point three!” becomes the dream.
One crate renewed, the burrow cheers,
Fresh version paws replace old years. 🐇

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes the main change: upgrading the OpenSecret SDK to 3.3.0.
Linked Issues check ✅ Passed The dependency bump to opensecret 3.3.0 matches the issue’s fix for base64 embedding responses.
Out of Scope Changes check ✅ Passed The PR only updates the OpenSecret SDK version, with no unrelated code changes evident.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex-embeddings-api-investigation-maple-proxy

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@AnthonyRonning
AnthonyRonning merged commit 4123f7f into master Jul 11, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedding API fails to deserialize base64

1 participant