Allow repeated SensorView copies in SensorData #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is relevant for e.g. sensor fusion models that merge multiple SensorData inputs into one SensorData output.
pmai
added
the
FeatureRequest
|
I am actually a bit confused by the "RadarSensorViewConfiguration" copy. I thought we only need a few values from that in every time step? |
Contributor
Author
|
The overhead of the config view is very slight compared to the radar data itself, and without the config information the raw data does not necessarily make sense: Consider the CameraSensorView data, which is just raw binary data, with the format completely described in the config. This also aids in getting the right data for multiple views, since they contain the configs... |
ghost
approved these changes
Mar 27, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relevant for e.g. sensor fusion models that merge multiple
SensorData inputs into one SensorData output.