Merged
Conversation
jdsika
reviewed
Oct 22, 2019
| // Visibility is unknown (must not be used in ground truth). | ||
| // | ||
| FOG_UNKOWN = 0; | ||
| FOG_UNKNOWN = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
This PR is based on this issue.
Add a description
This PR is a refactoring of test_cases.py and test_cases_doc.py and uses the builtin python unit testing framework to test the compliance of OSI comments. The test cases are implemented in a modular way which is easy maintainable and extensible with more test cases based on categories such as tabs, comments, messages, etc.. Using the unit testing framework will improve the code quality output of the OSI project.
The .travis.yml contains now the command
python -m unittest discover testswhich runs the unit tests.This PR also corrects a small typo of the
enum FogfromFOG_UNKOWN-->FOG_UNKNOWN.Mention a member
@jdsika pls review and let me know your thoughts.
Check the checklist