Skip to content

Unit tests comments compliance #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdsika merged 2 commits into from
Oct 22, 2019
Merged

Unit tests comments compliance #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c24566
Implemented unit tests for osi comment compliance and corrected typo …
vkresch Oct 22, 2019
b279926
Test comments only in *.proto files
vkresch Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ script:
- cmake -D CMAKE_PREFIX_PATH:PATH=${DEPS_DIR}/protobuf/install -D CMAKE_INSTALL_PREFIX:PATH=${TESTINST_DIR} ..
- cmake --build .
- cd ..
- python test_cases.py
- python setup.py build
- python setup.py sdist
- cd build
Expand All @@ -87,7 +86,7 @@ script:
- echo "GENERATE_TREEVIEW = YES" >> Doxyfile
- doxygen
- cd ..
- python test_cases_doc.py
- python -m unittest discover tests
- mv VERSION.SAVED VERSION
- sh convert-to-proto3.sh
- mkdir -p build3
Expand Down
2 changes: 1 addition & 1 deletion osi_environment.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ message EnvironmentalConditions
{
// Visibility is unknown (must not be used in ground truth).
//
FOG_UNKOWN = 0;
FOG_UNKNOWN = 0;
Copy link
Copy Markdown
Contributor

@jdsika jdsika Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesus, well spotted!


// Other (unspecified but known) fog intensity.
//
Expand Down
290 changes: 0 additions & 290 deletions test_cases.py
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions test_cases_doc.py
View file
Open in desktop

This file was deleted.

Empty file added tests/__init__.py
View file
Open in desktop
Empty file.
Loading