📝 docs(vercel): record the new root-directory failure and the exact fix - #51
Conversation
The `grab-url` Vercel project still has Root Directory `docs`, and now that PR #47 deleted that folder every deployment fails immediately after the clone with "The specified Root Directory "docs" does not exist" instead of the old missing-routes-manifest error. Same cause, different message. Update the architecture notes to describe the folder as deleted rather than on its way out, record both error messages, and spell out the dashboard settings that fix it (Root Directory → grab-help-docs, keep the outside-the-root include, clear the Install Command override). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7vgUYbDNrEhFEUEQ2Tuci
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The red
The module rewrite is intentional and documented in its JSDoc; the test file was simply not carried along. The two one-line ones: - it('uses the supplied base name but leaves the extension to yt-dlp', () => {
- const args = buildYtDlpArgs('https://youtu.be/x', { filename: 'My Video' });
- expect(args[args.indexOf('--output') + 1]).toBe('My Video.%(ext)s');
+ it('uses the supplied output template verbatim', () => {
+ const args = buildYtDlpArgs('https://youtu.be/x', { output: 'My Video.%(ext)s' });
+ expect(args[args.indexOf('--output') + 1]).toBe('My Video.%(ext)s');- expect(describeYtDlpExit(1)).toBe('download failed');
+ expect(describeYtDlpExit(1)).toBe('download failed — the media may be private, region-locked or removed');The other nine need the progress-parsing tests rewritten against the sentinel-line API, which is a change of its own rather than a drive-by on a docs PR — happy to do it in a follow-up. Generated by Claude Code |
What
Docs-only. The
grab-urlVercel project still has Root Directorydocs, and now that #47 deleted that folder every deployment fails one step earlier — immediately after the clone:instead of the old
"/vercel/path0/docs/.next/routes-manifest.json" couldn't be found. Same cause, different message —.claude/architecture/documentation.mdpredicted exactly this.Changes
.claude/architecture/documentation.md— thedocs/section now describes the folder as deleted (commitc894e60) rather than on its way out; the Vercel section records both error messages and spells out the dashboard settings that fix it..claude/architecture/conventions.md— the agent rules say don't recreatedocs/, and the "red Vercel check is not your diff" rule names the current failure.CLAUDE.md— link description updated.The actual fix (not in this diff)
Root Directory is a dashboard setting; no commit can change it. In Vercel → project
grab-url→ Settings → Build and Deployment:docs→grab-help-docsnpm install --prefix=..); leave Build Command and Output Directory unset —grab-help-docs/vercel.jsonsupplies all threeTesting
Documentation only — no code, build or test surface touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V7vgUYbDNrEhFEUEQ2Tuci
Generated by Claude Code