Skip to content

Add before/after figures to #294 (doubly-wrapped contour fix) #297

Description

@1-Bort-1

#294 is the case that motivated figures in PR cards, and it is still open, so retrofit it as the first instance. The card argues in numbers — cond(A) 1.07e3 → 2.52e11, y reaching -13013 on 9 of 45 sections — that a second shrink-wrap collapses the Kulfan fit. A reader cannot check that by reading the three-line diff, and the failure is entirely visual: the blown-up sections look nothing like an airfoil.

Wanted, using the existing exports in ext/VortexStepMethodMakieExt.jl where they fit (plot_airfoil_fit, plot_airfoils, plot_slices_3d, plot_section_polars) and new functions there only if they are worth shipping to users:

  • A 2D slice comparison for the SK100 sections that break — at least one of {6,8,9,10,12,16,27,29,43} — fit contour before the fix beside fit contour after, on identical axes, against the input contour that was handed in. The card notes 10_d10.dat looks normalised because it was rescaled by a large chord, so plot thickness rather than relying on the bounding box, or the figure will hide exactly the case the text warns about.
  • Section polars for the same sections, before and after, across several delta, since the fix moves generated polars for every user of both adapters and that is the change's real risk.

The before is rendered from the merge base in a separate worktree with the same inputs and the same axes limits as the after. Publish through the assets mechanism from 1-Bart-1/Agents once it exists; if that is not ready, say so on the PR and hold rather than committing PNGs to the source branch. Update .agent/card.md so the figures land in the description with a one-line caption each, and leave the existing text intact — the figures are evidence for the argument, not a replacement for it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions