Skip to content

Reduce compile time#65

Merged
janosg merged 14 commits intomainfrom
compile-time-2
Oct 28, 2021
Merged

Reduce compile time#65
janosg merged 14 commits intomainfrom
compile-time-2

Conversation

@janosg
Copy link
Copy Markdown
Member

@janosg janosg commented Oct 27, 2021

Second attempt at reducing compile time

  • Use jnp.where to handle missings in update
  • Get rid of pandas objects in likelihood function
  • Use cond instead of if conditions
  • Use scan instead of a for loop

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #65 (5a4f878) into main (b17ce92) will decrease coverage by 0.26%.
The diff coverage is 92.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   92.83%   92.57%   -0.27%     
==========================================
  Files          28       27       -1     
  Lines        2163     2194      +31     
==========================================
+ Hits         2008     2031      +23     
- Misses        155      163       +8     
Impacted Files Coverage Δ
skillmodels/simulate_data.py 86.88% <ø> (ø)
skillmodels/tests/test_params_index.py 100.00% <ø> (ø)
skillmodels/likelihood_function.py 84.35% <80.70%> (-3.36%) ⬇️
skillmodels/kalman_filters.py 100.00% <100.00%> (ø)
skillmodels/params_index.py 100.00% <100.00%> (ø)
skillmodels/parse_params.py 95.34% <100.00%> (-2.36%) ⬇️
skillmodels/process_data.py 94.59% <100.00%> (ø)
skillmodels/tests/test_kalman_filters.py 99.32% <100.00%> (+0.09%) ⬆️
skillmodels/tests/test_likelihood_regression.py 98.33% <100.00%> (ø)
skillmodels/tests/test_parse_params.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17ce92...5a4f878. Read the comment docs.

@janosg janosg requested a review from hmgaudecker October 27, 2021 16:23
@janosg janosg merged commit 16c21a4 into main Oct 28, 2021
@janosg janosg deleted the compile-time-2 branch October 28, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants