Refactor likelihood module#77
Merged
hmgaudecker merged 2 commits intoreduce-mem-usagefrom Sep 11, 2024
Merged
Conversation
…two modules with likelihood functions.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reduce-mem-usage #77 +/- ##
===================================================
Coverage ? 91.43%
===================================================
Files ? 40
Lines ? 3070
Branches ? 0
===================================================
Hits ? 2807
Misses ? 263
Partials ? 0 ☔ View full report in Codecov by Sentry. |
hmgaudecker
added a commit
that referenced
this pull request
Sep 11, 2024
…kelihood functions modules (#77) * Add a version of mem consumption test that fails if there are increases in the repo. * Decorate kalman_update, _calculate_sigma_points, with jax.checkpoint, can use `prevent_cse=False` due to being inside lax.scan, as per https://jax.readthedocs.io/en/latest/_autosummary/jax.checkpoint.html\#jax.checkpoint. * Use checkpoint() on kalman_predict as well, requires changing `transition_func` to be its first argument and using `jnp.array` in tests. * Provision for testing on GPUs, timing information is not useful yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maximization_inputs.py, import from two modules with likelihood functions._jax-suffixes from likelihood functions, seems like a leftover from transition days.