Building error on ORE 1.8.9 Windows

[rjabrazko]

Hi All,

I am trying to build ORE 1.8.9 using only the release tag for both ORE and QuantLib, but I have the following errors during building in VS 2019

Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open source file: 'ored\configuration\smiledynamicsconfig.cpp': No such file or directory	OREData	C:\ore\OREData\c1xx	1	
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1083	Cannot open include file: 'oret/config.hpp': No such file or directory	QuantExtTestSuite	C:\ore\QuantExt\test\testsuite.cpp	27	
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1104	cannot open file 'OREData-x64-mt.lib'	OREDataTestSuite	C:\ore\OREData\test\LINK	1	
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1104	cannot open file 'OREData-x64-mt.lib'	ore	C:\ore\App\LINK	1	
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1104	cannot open file 'OREData-x64-mt.lib'	OREAnalyticsTestSuite	C:\ore\OREAnalytics\test\LINK	1
}

It seems that the file "smiledynamicsconfig.cpp" is missing in OREData, which is the case after checking

Any ideas what might be wrong here? only using release tag...no git no clone

Regards

Reda

[rkapl123]

Hi, this is due to the VS project files not being closely monitored. The mentioned smiledynamicsconfig.cpp and smiledynamicsconfig.hpp have been removed in 1.8.9, so you can remove them safely from the VS project as well.
I'm currently fixing other things that are missing and I'm going to submit a PR with this as well.

regards,
Roland

[rjabrazko]

Hi Roland,

Thanks for your reply. I managed to add the missing smiledynamicsconfig.cpp and smiledynamicsconfig.hpp for old ORE version and it works for building OREData successfully. However all the TestSuite Projects building has failed due to the Testsuite.cpp not properly configured I think.
I forgot to mention ealier that I added a MSVC folder that was missing in the release tag (with ore.x64.user.props and ore.Win32.user.props) from older version to be able to load the project in VS.
When you said submitting a PR you mean a new release tag?
Thanks
Regards
Reda

[pcaspers]

Hi guys

sorry this is an oversight on our side: The windows project files should have been removed in the 1.8.9.0, we don't support them anymore. We'll fix this asap. See here how to proceed with the windows build:

https://github.com/OpenSourceRisk/Engine/blob/master/Docs/UserGuide/userguide.tex#L685

[rkapl123]

Dear Peter, I see your point and thank you for clarifying this, so I'll spare the PR (pull request) and think of something separately.
Essentially I've added all the missing files now and everything builds fine in visual studio (2022). I think the Visual studio filters are not too helpful here, so I'm just using the filesystem directly.
I'm wouldn't like to abandon Visual Studio support, as I'm actively using visual studio to modify and debug ORE, so I'd like to contribute the necessary files in a separate git project, referring to the ORE sources.
Would that be OK for you?

[pcaspers]

Hi Roland, we still support the Visual Studio IDE, but we now rely on cmake to generate the project files instead of maintaining them manually, see the user guide. Will that work for you? This way we have to maintain only one build system.

[rkapl123]

Well, I'm using the cmake tool to build ORE without the IDE and I think it works very well, but to use it as a replacement for the nice and tidy oreEverything.sln

this is a bit tedious for navigating/editing/debugging:

I think I'm going forward with my separated OREVisualStudio, I just need a way to automatically add the files as cmake does.

[pcaspers]

Ok - actually I am not sure if this is the best way to work from Visual Studio IDE. I'll ask a windows guy on our side to comment on this!

[rjabrazko]

Hi Roland,

I used the cmake as described by Peter but I have only 39 projects, and you have 42 projects in your screenshot

What is the right number?
Reda

[rkapl123]

Dear Reda, I don't know and I don't use cmake that way. You can go forward with the build commands described in the Userguide, although I haven't used the ninja build system yet.
I've contributed a small cmd script in the main directory called runCmakeVS.cmd, which uses cmake to both create the project files and afterwards build ORE itself (EDIT: to work with VS 2019, the generator name option might have to be "Visual Studio 16 2019", although after upgrading to Version 16.11 this wasn't necessary any more).
You have to watch out for the documentation/doxygen builds, if you don't have doxygen/graphviz installed, then this will fail. I'd uncomment the line option(ORE_BUILD_DOC "Build documentation" ON) in the file CMakeLists.txt if you don't care about documentation.

[rjabrazko]

Hi Roland,

Thanks for the clarifications. Personally, I prefer the old version of ORE where you have the nice oreEverything.sln as you said.
Now we have to generate the VS project with cmake, I will take a look at cmd script you mentioned after installing Doxygen.
The three projects that you have more are only related to doc I guess...which I don't have with cmake

Thank you very much
Regards
Reda

[rkapl123]

I've managed to make a detached copy (in a separate folder) of the current VS project files working, and I'm finishing the automated update of those with the CmakeLists in ORE.
Once that is done, you can download this from my GitHub account.

Regards
Roland

[rkapl123]

OK, after a while I managed to create an oreEverything.sln + project files in https://github.com/rkapl123/OREVisualStudio, being able to update from the CmakeLists in ORE's source tree using a powershell script.

I'm still struggling a bit with the test scripts executed within visual studio's test browser, this seems to be a path related problem reading the config xmls. Outside of visual studio the tests run without an error message.

The path problem was fixed by adding
<PropertyGroup> <LocalDebuggerWorkingDirectory>$(ORE)\OREData\test\bin</LocalDebuggerWorkingDirectory> </PropertyGroup>
to the project file at the end. Now the tests also run within visual studio

[mgroncki]

It is possible to open the CMake project directly with Visual Studio without the visual studio solution/project files and then you can modify ORE and debug it within Visual Studio (https://learn.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=msvc-170)

Select the build system and configuration (MSbuild / Ninja, RelWithDebInfo/ Debug)

Select the startup item (e.g. ORE App)

There are also all solution files listed, but the relevant item is executable. It is possible to filter the list with show/hide debug target

There are a few changes though:

1. You won't see the used project and filter structure but the folder structure as it is on the file system

2. The executables are built in the subfolder /build/TARGET/CONFIGURATION/EXECUTABLE, e.g. /build/App/Release/ore.exe
3. The debug and launch settings are set in launch.vs.json and not in a GUI

Depending on your visual studio you may need to adjust the generator in the CMakePresets.json, it is set to "generator": "Visual Studio 17 2022"

[mgroncki]

Just noticed, there is a reference to the VCPKG package manager in the CMakePreset.json. We need to remove it.

In the CMakePreset.json:

• Remove the lines with "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"

• If you haven't doxygen installed add the line to the cache variables: "ORE_BUILD_DOC": false

I will open a PR for this.

[rkapl123]

Dear Mathias!
Thanks a lot for pointing out this (for me) new possibility of Visual Studio, I managed to even make it work in VS 2019, there is even a menu item for opening CMakeLists directly.
Two things are a bit disturbing though, 1) there's no integration with the test explorer (at least I couldn't find one) and 2) I also couldn't find a way/target to directly build libraries (like OREdata, QuantExt, QuantLib etc.), only exe targets can be built.
I think it's OK to have more than one way to work with ORE source, even now as the updating is rather simple from CMakeLists using my script.