Skip to content

Add in-place SPSS transformation profile - #3

Merged
TonisOrmisson merged 1 commit into
mainfrom
codex/transformation-plan-profile
Jul 31, 2026
Merged

Add in-place SPSS transformation profile#3
TonisOrmisson merged 1 commit into
mainfrom
codex/transformation-plan-profile

Conversation

@TonisOrmisson

Copy link
Copy Markdown
Contributor

Defines a canonical product-neutral Transformation Plan and bounded SPSS-like frontend for RECODE, VARIABLE LABELS, and VALUE LABELS. Adds direct same-dataset/same-table in-place binding, compact audit, conformance fixtures, docs, and validation gates. Dolt branch/HEAD checks are additive; no OpenStatSpec undo, copy, snapshot, or derived-dataset layer.

@TonisOrmisson
TonisOrmisson merged commit d8f0a87 into main Jul 31, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 944743c417

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +7 to +8
"": {
"typed_value": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the JSON Schema definition and reference keywords

With any Draft 2020-12 validator, the empty-string keyword here is ignored instead of defining typed_value, and the corresponding empty-string keyword on line 58 is ignored instead of referencing it. Consequently, frontend requests containing malformed existing value-label values—such as an integer or an arbitrary object—pass the published request schema, defeating the normative structural validation; use $defs here and $ref: "#/$defs/typed_value" at the value property.

Useful? React with 👍 / 👎.

@TonisOrmisson
TonisOrmisson deleted the codex/transformation-plan-profile branch July 31, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant