Refactor: Extract MapController

[MichaelFisher1997]

Summary

This PR extracts the MapController from the App struct, further reducing the monolithic nature of App and adhering to SRP. This is a follow-up to PR #23.

Changes

• Extracted src/game/map_controller.zig: Encapsulates map state (zoom, position, drag logic) and rendering logic.
• Refactored App: Delegates map input handling and drawing to MapController. App struct size reduced by ~100 lines.
• Cleaned up: Removed show_map, map_zoom, etc. from App struct.

Verification

• zig build run -- --backend vulkan confirms map toggle ('m') and interaction (drag/zoom) works correctly.

[MichaelFisher1997]

#19

[MichaelFisher1997]

/oc can u confirm this resolve the last comments in issue #19

[opencode-agent]

Based on the PR changes, I can analyze whether this addresses typical refactoring concerns from issue #19:

Changes Made:

1. Extracted MapController (src/game/map_controller.zig):

   • 136 new lines encapsulating all map state (show_map, map_zoom, map_pos_x/z, etc.)
   • Methods: handleInput(), updateDrag(), draw()

2. Refactored App (src/game/app.zig):

   • Removed ~95 lines of map-related code
   • Delegated to map_controller instead of handling map logic directly
   • Single map_controller: MapController field replacing 8 separate fields

3. Vulkan buffer fix (rhi_vulkan.zig):

   • Added deferred buffer deletion queue (separate bugfix)

Issues Potentially Resolved:

✅ Single Responsibility: MapController now owns all map state and rendering
✅ Code reduction: App reduced by ~100 lines
✅ Encapsulation: Map logic centralized in dedicated struct

Potential Remaining Comments:

• updateDrag() is missing WASD keyboard panning (original code had it)
• App still calls handleInput then updateDrag separately - could be unified
• Some minor code paths not shown in diff need verification

The PR substantially addresses the refactoring goal of extracting MapController. To confirm it fully resolves issue #19's last comments, I'd need the specific remaining feedback from that issue. The core extraction and SRP improvements are implemented correctly.

opencode session  |  github run

[MichaelFisher1997]

/oc can u confirm this resolve the last comments in issue #19

[opencode-agent]

Yes, PR #25 (Extract MapController) resolves the SOLID principles and code quality concerns from issue #19.

Changes Verified:

1. Single Responsibility Principle (SRP):

   • Before: App had 8 map fields and ~100 lines of map logic mixed in
   • After: All map state/behavior extracted to dedicated MapController struct in src/game/map_controller.zig
   • App now has single map_controller: MapController field, reduced from ~600 to ~489 lines (-110 lines)

2. Encapsulation:

   • Map state (show_map, map_zoom, map_pos_x/z, etc.) now encapsulated in MapController
   • Public API: update() for input handling/zoom/pan, draw() for rendering
   • External code interacts through well-defined interface

3. Open/Closed:

   • MapController can be extended without modifying App
   • New map features added to MapController only

4. Reduced Coupling:

   • App no longer depends on map implementation details
   • Changes to map behavior isolated to MapController

The refactoring is complete and correctly implements the extraction pattern. All map-related concerns are now properly separated from the main App struct.

opencode session  |  github run