test: add region role worldgen report coverage

[MichaelFisher1997]

Summary

• Add deterministic terrain report profiles for transit, boundary, and destination focus region controls.
• Include role-effect height, slope, vegetation, mask, mountain, and biome-count coverage in worldgen-report.
• Add tests confirming transit remains calmer, boundary remains rougher than transit, mountain destination shows stronger terrain drama, and forest destination keeps stronger vegetation/subbiome controls.

Verification

• nix develop --command zig fmt modules/world-worldgen/src/terrain_report.zig
• nix develop --command zig build test
• nix develop --command zig build worldgen-report

Fixes #659

[github-actions]

📋 Summary

Linked Issue: Fixes #659 ("Worldgen Phase 3: validate region role interaction with biome selection")

The PR fully addresses issue #659 by adding deterministic terrain report profiles for all five region roles (transit, lake_destination, forest_destination, mountain_destination, boundary). It integrates role-effect sampling into sampleRegion, outputs the data in writeReport, and adds tests confirming the key pacing controls: transit is calmer than boundary, mountain destinations show stronger height drama, and forest destinations maintain higher vegetation/subbiome controls. The acceptance criteria from the issue are satisfied.

📌 Review Metadata

• Reviewed Commit SHA: ede072f58b11a5961dfc21786d0f2c127c6795bd
• Reviewed PR: test: add region role worldgen report coverage #676

🔴 Critical Issues (Must Fix - Blocks Merge)

None identified.

⚠️ High Priority Issues (Should Fix)

None identified.

💡 Medium Priority Issues (Nice to Fix)

None identified.

ℹ️ Low Priority Suggestions (Optional)

None identified.

📊 SOLID Principles Score

Principle	Score	Notes
Single Responsibility	9	terrain_report.zig already handles report generation; role profiles are a natural extension of that responsibility.
Open/Closed	8	Adding RoleEffectProfileId variants requires extending the switch in regionInfoForProfile, but the rest of the report logic is unchanged.
Liskov Substitution	10	No inheritance; new struct integrates cleanly with existing TerrainReport.
Interface Segregation	9	RoleEffectProfile exposes only relevant metrics; helper functions are private.
Dependency Inversion	8	Relies on region_mod and TerrainShapeGenerator abstractions already in use.
Average	8.8

🎯 Final Assessment

Overall Confidence Score: 92%

How to interpret: 81-100%: High confidence, ready to merge or with trivial fixes

Confidence Breakdown:

• Code Quality: 95% (Clean Zig conventions, proper allocator usage with defer, good error handling)
• Completeness: 95% (All acceptance criteria from Worldgen Phase 3: validate region role interaction with biome selection #659 are tested and verified)
• Risk Level: 85% (Purely additive test/reporting code with no runtime engine changes)
• Test Coverage: 95% (Determinism, metric bounds, and role-comparison tests all present and passing)

Merge Readiness:

• All critical issues resolved
• SOLID average score >= 6.0
• Overall confidence >= 60%
• No security concerns
• Tests present and passing (if applicable)

Verdict:

MERGE

Well-structured, additive test coverage that fully satisfies issue #659 with passing tests and correct formatting.

Machine Readable Verdict

{
  "reviewed_sha": "ede072f58b11a5961dfc21786d0f2c127c6795bd",
  "critical_issues": 0,
  "high_priority_issues": 0,
  "medium_priority_issues": 0,
  "overall_confidence_score": 92,
  "recommendation": "MERGE"
}

opencode session  |  github run