fix(splash): don't interrupt other apps' audio on cold start#125
Merged
abdulsaheel merged 1 commit intoJul 21, 2026
Merged
Conversation
The muted splash video still requested audio focus, so on a cold start Edge paused whatever the user was already playing. Pass VideoPlayerOptions(mixWithOthers: true) so the splash mixes instead of interrupting.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe splash video controller now uses ChangesSplash audio behavior
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124 (thanks @batram for the report and the fix).
Problem
On a cold start Edge plays the splash video (
assets/splash/splashscreen.mp4). Even though it's muted, theVideoPlayerControllerstill requests audio focus, so it pauses whatever the user is already playing (music, podcast, etc.).Fix
Pass
VideoPlayerOptions(mixWithOthers: true)to the splash controller so it mixes with existing audio instead of interrupting it.One line, no behavioural change to the splash itself (still muted, still freezes on the last frame).
Testing
Verified by inspection — reproduces the reporter's fix. Not runtime-tested (no device/Flutter SDK to hand); the change is confined to the splash controller options.
Summary by CodeRabbit